Giter VIP home page Giter VIP logo

Comments (6)

andre-r avatar andre-r commented on June 15, 2024

@sir4ur0n Can you please make a PR to make your change backward compatible?

from centered-cursor-mode.el.

sir4ur0n avatar sir4ur0n commented on June 15, 2024

I am not very good with Elisp, so I don't know how this should be addressed 😅
My fix in #25 was pure cargo-culting already

from centered-cursor-mode.el.

ttybitnik avatar ttybitnik commented on June 15, 2024

I can share a temporary hotfix based on what I did in my local copy. It ain't optimal though, I just encapsulated the changed function and variable behind a version check, and kept the original ones in the else.

Just a moment.

from centered-cursor-mode.el.

ttybitnik avatar ttybitnik commented on June 15, 2024

Again, this is not optimal, but you can use it meanwhile if you wish, @andre-r.

It would be nice to test in 29.1 if it will, de facto, be merged. I cannot do that atm.

from centered-cursor-mode.el.

andre-r avatar andre-r commented on June 15, 2024

@ttybitnik Please test the latest version.

from centered-cursor-mode.el.

ttybitnik avatar ttybitnik commented on June 15, 2024

Working like a charm, @andre-r. Thank you both for caring for this package 👍

from centered-cursor-mode.el.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.