New fava version breaks fava_dashboards about fava-dashboards HOT 6 CLOSED

Resolved by #9 (already merged).

from fava-dashboards.

I'm using fava==1.25.1 and seeing this error when trying to launch fava_dashboards

Importing module "fava_dashboards" failed. 
Error: "cannot import name 'FavaAPIError' from 'fava.helpers'
(/home/addison/venv/beancount/lib/python3.9/site-packages/fava/helpers.py)"

Oddly enough the class exists in the mentioned file

$ grep FavaAPIError /home/addison/venv/beancount/lib/python3.9/site-packages/fava/helpers.py
class FavaAPIError(Exception):

Any thoughts?

from fava-dashboards.

@addisonklinke I cannot reproduce this error with fava 1.25.1. Can you try deleting the venv and re-installing everything?

from fava-dashboards.

Restarted my Fava server and that fixed the issue (in comparison re-loading did not)

from fava-dashboards.

Follow-up question - are changes to dashboards.yaml expected to be picked up by Fava's re-load detection? I see the yellow icon if I alter my .beancount file(s), but no prompt for changing dashboards. Manually refreshing the page works though

from fava-dashboards.

Follow-up question - are changes to dashboards.yaml expected to be picked up by Fava's re-load detection?

No, afaics that only works for beancount files.

from fava-dashboards.