Giter VIP home page Giter VIP logo

Comments (3)

donut avatar donut commented on June 24, 2024

Well, I feel dumb. Just needed to run xcode-select --install to install the Xcode command line utilities. Once they were installed, the paths were set properly.

from ocaml-mariadb.

andrenth avatar andrenth commented on June 24, 2024

I think a diff like this could work for the configure script. Do you think it's needed?

diff --git a/configure b/configure
index b85310d..43b3885 100755
--- a/configure
+++ b/configure
@@ -9,12 +9,18 @@ include_base=""
 mariadb_connector="false"
 mariadb_as_mysql="false"
 
-if detect -lmariadb; then
+mariadb_include=`mariadb_config --include 2>/dev/null || echo ""`
+mariadb_libs=`mariadb_config --libs 2>/dev/null || echo "-lmariadb"`
+
+mysql_include=`mysql_config --include 2>/dev/null || echo ""`
+mysql_libs=`mysql_config --libs 2>/dev/null || echo "-lmysqlclient"`
+
+if detect $mariadb_include $mariadb_libs; then
   include_base="mariadb"
   mariadb_connector="true"
 elif detect -lmariadbclient -DMARIADB_CLIENT; then
   include_base="mysql"
-elif detect -lmysqlclient -DMARIADB_CLIENT; then
+elif detect $mysql_include $mysql_libs -DMARIADB_CLIENT; then
   include_base="mysql"
   mariadb_as_mysql="true"
 fi

from ocaml-mariadb.

donut avatar donut commented on June 24, 2024

It definitely would have saved me some time and could probably solve some other weird cases where these files aren't in /usr/local/*. But this is just the detect phase. Could there possibly be problems at points farther down the line with installation and runtime if Xcode CL utilities haven't been setup properly?

Maybe it'd be better to add to the error message that Xcode command line utilities may not have been setup yet?

from ocaml-mariadb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.