Giter VIP home page Giter VIP logo

Comments (11)

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024 2

At last!
https://github.com/andrewdavidmackenzie/libproc-rs/actions/runs/8267240156/job/22617146403?pr=128

There was a bug in my GH Action that hid this. I will now push a fix and release later tonight.
(annoyingly, I cannot reproduce in local with act either :-( )

from libproc-rs.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024 2

Fixed and a new minor version pushed to crates.io.
https://crates.io/crates/libproc/0.14.6

I'll do the github release later tonight.

from libproc-rs.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024 1

OK, reproduced locally - now I need to "fix" (i.e. break) CI....

from libproc-rs.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024

from libproc-rs.

devyn avatar devyn commented on June 6, 2024

Yes. Thanks!

from libproc-rs.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024

I'm not seeing the failure in CI on 1.74.1 or locally (on macos using act).
PR (so far just added that version of rust to the matrix) here

Any ideas?

from libproc-rs.

fdncred avatar fdncred commented on June 6, 2024

These are the errors it's giving in nushell. I think ptr_from_ref may have been stabilized recently.

error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/proc_pid.rs:241:22
    |
241 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidinfo).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/pid_rusage.rs:389:22
    |
389 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidrusage).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/file_info.rs:168:22
    |
168 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidinfo).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

from libproc-rs.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on June 6, 2024

Can you give some more details about where those errors are from, OS versions, rustc versions etc - as I'd like to reproduce the problem in CI before putting in place fixes for it, and controls to avoid a re-occurrance?

When I try with stable 1.74.1 on macos and linux, I do not see those failures.

thanks

from libproc-rs.

fdncred avatar fdncred commented on June 6, 2024

Sure. They're from me building nushell with cargo install --path . --features=dataframe

❯ sw_vers
ProductName:            macOS
ProductVersion:         14.4
BuildVersion:           23E214

❯ rustc --version --verbose
rustc 1.74.1 (a28077b28 2023-12-04)
binary: rustc
commit-hash: a28077b28a02b92985b3a3faecf92813155f1ea1
commit-date: 2023-12-04
host: aarch64-apple-darwin
release: 1.74.1
LLVM version: 17.0.4

from libproc-rs.

fdncred avatar fdncred commented on June 6, 2024

Thanks so much for your help and responsiveness @andrewdavidmackenzie !!!

from libproc-rs.

devyn avatar devyn commented on June 6, 2024

Seconded. Thank you!

from libproc-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.