Compilation issues with recent gfortran versions (6.4.1 and 7.3.1) about fox HOT 4 OPEN

Thanks for this. So I should also add more gcc compilers to the mix of the CI. What fun!

I think the latest suggestion in the gcc bug report (just move the checkFmt function to the top of the file) will give us something that compiles with the latest gcc compilers (working around the bug) and is valid Fortran 2008. I say think because I am struggling a bit with:

If a specification expression in the specification-part of a module or submodule includes a reference to a generic entity, that generic entity shall have no specific procedures defined in the module or submodule subsequent to the specification expression.
(Paragraph 9 of section 7.2.11 of the Fortran2008 specification)

We don't reference the generic entity in checkFmt so this compiler bug workaround should be OK. But validating this for the Cray compiler (which seems to be the only compiler that enforces this constraint) would be useful. I wonder if NAG does this yet...

from fox.

Yes it works with gfortran and pgi. Much simpler that I was afraid.
There is also another function get_TextContent_len to move upwards, It is in dom/m_dom_dom.F90, should be done in the m4 file but I don't know how to do.
I will do more tests with intel and let you know

from fox.

Just writing to say that I experienced the same problems as above with gfortran (7.3.0), moved the functions checkFmt and get_TextContent_len as suggested, and I was able to build successfully.

from fox.

Sorry for the delay!

At least a partial fix to this is at libAtoms@1eef739 and/or ye-luo@e4d0479

Looks like the gfortran bug ended up getting fixed and the fix got back ported (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85138) but I don't see a problem with these fixes. I'll pull together a patch

from fox.