Comments (5)
Could you provide more info about the problem you have?
from performance-samples.
No problem, just a suggestion for the sample.
In the benchmark sample, the build setup uses a release target, which as a sample probably isn't something we would advise developers to follow.
https://github.com/android/performance-samples/blob/main/BenchmarkSample/benchmark/build.gradle
The ui module doesn't define any build variants, so presumably just has debug and release.
from performance-samples.
@mlykotom apologies for the terrible bug report, I keep forgetting the context I have in my head when I drop a quick bug.
from performance-samples.
the build setup uses a release target, which as a sample probably isn't something we would advise developers to follow.
Why do you say this isn't something to advise? Benchmarks are in their own separate module, so it's not necessary to create a new buildType, separate from release. Nothing should ever take a dependency on a release library module that's only used for tests.
For macrobenchmark, what you're saying is true, which is why we recently changed it to use a separate benchmark
build type, since it interacts with the app module. Now both match the Studio module template behavior in Bumblebee - release
for the (micro)benchmark module, benchmark
for the macrobench module.
from performance-samples.
Thanks, I'll close then.
from performance-samples.
Related Issues (20)
- Package x.y.z must not be running prior to cold start! HOT 6
- Benchmark Tests do not run in Android Version 11 HOT 2
- Need examples on how to benchmark suspending functions in microbenchmark
- Switch to benchmark test runner HOT 4
- jankFrameListener run 2 times for onCreate HOT 5
- How can you pull the baseline profile in CI? HOT 3
- Getting Could not find com.squareup.okio:okio-bom:2.8.0. HOT 1
- TestRunner: java.lang.IllegalStateException: Perfetto tracing failed to start. HOT 1
- Does matchingFallbacks work if libraries are imported via releaseImplementation and debugImplementation? HOT 2
- Samples doesn't work for dynamic feature modules HOT 4
- Does Baseline Profile just helps with very First launch HOT 1
- [JankStat] [Feature] Provide expectedDuration of Frame in FramaData HOT 1
- java.io.FileNotFoundException - perfetto-trace HOT 2
- Fix GitHub build for macrobenchmark sample
- A question about just one baseline-prof.txt(PR : #258) HOT 4
- Question about the difference in file size inside the aab depending on the location of the generated baseline-prof.txt file
- Fix the GitHub Actions build by not executing benchmarks on an emulator
- Failing to run assembleDebugAndroidTest in MacrobenchmarkSample app
- Why macrobenchmark module's build.gradle has "isDebuggable = true" HOT 1
- Failing tests in the Macrobenchmark sample
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from performance-samples.