Giter VIP home page Giter VIP logo

Comments (5)

yceballost avatar yceballost commented on June 15, 2024

+1

from copycat-action.

leighajarett avatar leighajarett commented on June 15, 2024

+1

from copycat-action.

andstor avatar andstor commented on June 15, 2024

Hi !

Internally, the exclusion pattern matching is done against a string path. However, it seems that the this string path does not include a leading slash. So currently, to ignore top level files or directories, just don't include a slash at the beginning of the exclude expression. To ignore the .github folder in the root directory, just set the exclude pattern to .github/*.

However, as it is normal to address a root path with a leading slash, this might be beneficial to implement. This would be a breaking change, so we need to be sure that this is the most intuitive and conventional solution. The actual fix seems to be rather simple.

Just change this line:

[[ "$f" == $EXCLUDE ]] && continue

to this:

[[ "/$f" == $EXCLUDE ]] && continue 

This would make it possible to exclude the root directory with the pattern /.github/* or */.github/*. However, the pattern .github would no longer work.

Feedback is much appreciated πŸ™

from copycat-action.

markcheret avatar markcheret commented on June 15, 2024

it wasn't working for me either and I figured it out by experimentation. Even though it is a breaking change, I highly encourage to implement it.

from copycat-action.

josesoaresif avatar josesoaresif commented on June 15, 2024

Is it possible to exclude more than one folder?

from copycat-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.