htop quits unexpectedly after SortBy (with workaround) about htop-osx HOT 7 OPEN

The fuFunctions array for the Sort Screen's FunctionBar is not ended with a NULL Pointer, thus strdup reads from invalid address when creating this FunctionBar. The following patch (unified diff) adds a NULL Pointer to the two fuFunctions arrays in htop.c not ending in an NULL pointer:

--- htop.c.orig 2010-01-13 18:04:07.000000000 +0100
+++ htop.c 2010-01-13 15:29:55.000000000 +0100
@@ -651,7 +651,7 @@

      Panel* affinityPanel = AffinityPanel_new(pl->processorCount, curr);

•     char\* fuFunctions[2] = {"Set    ", "Cancel "};
  

•     char\* fuFunctions[] = {"Set    ", "Cancel ", NULL};
    void\* set = pickFromVector(panel, affinityPanel, 15, headerHeight, fuFunctions, defaultBar);
    if (set) {
       unsigned long new = AffinityPanel_getAffinity(affinityPanel);
  

  @@ -690,7 +690,7 @@
  {
  Panel* sortPanel = Panel_new(0, 0, 0, 0, LISTITEM_CLASS, true, ListItem_compare);
  Panel_setHeader(sortPanel, "Sort by");

•     char\* fuFunctions[2] = {"Sort  ", "Cancel "};
  

•     char\* fuFunctions[] = {"Sort  ", "Cancel ", NULL};
    ProcessField\* fields = pl->fields;
    for (int i = 0; fields[i]; i++) {
       char\* name = String_trim(Process_fieldTitles[fields[i]]);
  

from htop-osx.

Sorry, I forgot the

 tags!

--- htop.c.orig 2010-01-13 18:04:07.000000000 +0100
+++ htop.c  2010-01-13 15:29:55.000000000 +0100
@@ -651,7 +651,7 @@
          
          Panel* affinityPanel = AffinityPanel_new(pl->processorCount, curr);
 
-         char* fuFunctions[2] = {"Set    ", "Cancel "};
+         char* fuFunctions[] = {"Set    ", "Cancel ", NULL};
          void* set = pickFromVector(panel, affinityPanel, 15, headerHeight, fuFunctions, defaultBar);
          if (set) {
             unsigned long new = AffinityPanel_getAffinity(affinityPanel);
@@ -690,7 +690,7 @@
       {
          Panel* sortPanel = Panel_new(0, 0, 0, 0, LISTITEM_CLASS, true, ListItem_compare);
          Panel_setHeader(sortPanel, "Sort by");
-         char* fuFunctions[2] = {"Sort  ", "Cancel "};
+         char* fuFunctions[] = {"Sort  ", "Cancel ", NULL};
          ProcessField* fields = pl->fields;
          for (int i = 0; fields[i]; i++) {
             char* name = String_trim(Process_fieldTitles[fields[i]]);
from htop-osx.

AndyA can you add this patch to your repo?

from htop-osx.

how can I apply that patch to my copy?

from htop-osx.

Something like: `patch -u < FILE'. See the patch man-page for more details.

from htop-osx.

I can confirm that applying this patch worked for me. Thanks!

from htop-osx.

See my recent comment/pull request for the applied patch. Hopefully AndyA will accept it since I like htop on osx and this was the one bug that was buggin' me. :)

from htop-osx.