Giter VIP home page Giter VIP logo

Comments (2)

RingsC avatar RingsC commented on July 20, 2024

commit 59504c14c2cc5d2472d043c2487460db5b82a547
Author: Roy Lyseng [email protected]
Date: Sat Nov 21 18:02:45 2020 +0100

Bug#32079103: Assertion failure: trx->lock.table_locks.empty()

The symptom for this problem is that we may have an inconsistent
InnoDB transaction after creating a non-InnoDB table from a
query expression that operates on InnoDB tables.
The cause of this is the refactoring that moved creating the
new table into Query_result_create::start_execution().
Before that, the new table was created in
Query_result_create::prepare(), however with single preparation,
it could not be created as part of query preparation.

The problem with the new strategy was that table creation would
occur after locking the tables of the query expression, and thus
the implicit commit of the table creation would clear the locks.
As a result, evaluating the query expression would access unlocked
InnoDB tables, leading to an inconsistent InnoDB state.
When the session was immediately terminated, the InnoDB transaction
state checker would report a problem.

The solution to the problem is to remove the table creation from
Query_result_create::start_execution() and place it in a new function
Query_result_create::create_table_for_select(). We also implement a
**simplified version of handle_query() called populate_table()**, since
the former is not really designed for DDL statements that perform
intermediate commits.

**handle_query() itself is removed because it is no longer in use.**

Reviewed by: Gopal Shankar <[email protected]>
Reviewed by: Chaithra Gopalareddy <[email protected]>

from mysql-server-mysql-8.0.30.

RingsC avatar RingsC commented on July 20, 2024

simplified version of handle_query() called populate_table()
and handle_query() itself is removed because it is no longer in use. @andyli029 @DandreChen @lujiashun

from mysql-server-mysql-8.0.30.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.