Giter VIP home page Giter VIP logo

Comments (4)

TerjeLon avatar TerjeLon commented on September 15, 2024

Not all passports follow the ICAO standard regarding listing Datagroups in the COM's 5C tag. They actually list some elements in the COM 5C tag that is not in the ICAO-standard.

This should perhaps not give an error, as reading the passport itself should be fine.

Perhaps a solution here could be to return the PassportModel in the callback instead of an error, and add a "warning/errors" parameter to the Model so consumers can be notified of the deviations that has occured.

So what actually happens here is that a DG-group is listed in the COM, but it does not actually exist. So it should be skipped instead of throwing

from nfcpassportreader.

advatar avatar advatar commented on September 15, 2024

I have noticed this too. There can be 19 DataGroups but the app only supports to 16. Try and add DG17-19 with no parsing.

from nfcpassportreader.

TerjeLon avatar TerjeLon commented on September 15, 2024

I have noticed this too. There can be 19 DataGroups but the app only supports to 16. Try and add DG17-19 with no parsing.

Theres no official documentation on those datagroups.

i will try to create a pr for this when i have the time

from nfcpassportreader.

TerjeLon avatar TerjeLon commented on September 15, 2024

@iAbdul could you try again with the branch on the PR above and see if this fixes it for you?
@advatar did you have any documents you could try on? Testing is much appreciated as i dont have any documents on hand.

Please comment in the PR so that if/when @AndyQ eventually gets around to it he can see that the fix is verified.

from nfcpassportreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.