gnome-shell error log flood: Object St.Button (...), has been already disposed about simply-workspaces HOT 2 CLOSED

Dig & Reproduce method

// this bothered me for a while, finally I found it

0. monit syslog by tail -f /var/log/syslog

1. gnome session lock (Ctrl+L) & unlock.
   OR Ctrl+Alt+F1 & login,
   OR hibernate & wakeup.
   OR extensions disable & enable.
   // trig disable(), enable(), leak callback

2. open some window,
   OR close some window.
   // trig leaked callback of window-added window-removed
   .
   then error log occur in syslog

// some one never poweroff system (always hibernate), the syslog size growing fast.
// error effect (callback leak) accumulate at each session unlock.

avoid

restart gnome-shell by Alt+F2 r Enter
// at each session unlock

source fix

diff --git a/extension.js b/extension.js
index d116a8b..34bfdc1 100644
--- a/extension.js
+++ b/extension.js
@@ -75,10 +75,10 @@ const attachHandlers = () => {
     return () => {
       workspace.disconnect(windowAdded);
       workspace.disconnect(windowRemoved);
-      instance.disconnect(nodeClick);
+      instance.node.disconnect(nodeClick);
     };
   });
-  handlers.concat(workspaceHandlers);
+  handlers.push(...workspaceHandlers);
 };
 
 const detachHandlers = () => {

// Array.concat() return new array, not modify self.

from simply-workspaces.

Thanks for opening this, and catching that concat bug. I'll give this a try over the next few days

from simply-workspaces.