Giter VIP home page Giter VIP logo

Comments (6)

Hyuchiha avatar Hyuchiha commented on August 15, 2024 2

I make a pull request with an improvement of your fix, it passes the test now

from angular2-trim-directive.

anein avatar anein commented on August 15, 2024

Hi there!

Yes, there's this issue.

from angular2-trim-directive.

AlexeyBogdan95 avatar AlexeyBogdan95 commented on August 15, 2024

@anein Actually, I have a branch which contains a fix for this issue, but I can't push it to origin. How can I do it? Thank you!

from angular2-trim-directive.

anein avatar anein commented on August 15, 2024

@AlexeyBogdan95 Как обычно. И если есть возможность, то добавь, пожалуйста, тесты, которые проверяют решение. =) https://help.github.com/articles/about-pull-requests/

from angular2-trim-directive.

anein avatar anein commented on August 15, 2024

For some reason the solution doesn't pass the tests. =\

from angular2-trim-directive.

anein avatar anein commented on August 15, 2024

@Hyuchiha Done and done! Thank you for fixing this old bag. 👍

from angular2-trim-directive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.