Can't find controllers about angularjs-eclipse HOT 16 CLOSED

At first I suggest you to set scriptpath not for "third-party libraries" which can be big and load of tern server could be very slow. I must improve the load of big JS files with a Tern Builder angelozerr/tern.java#5 and I think the best idea is to stores in a DB teh JS files parsed (in tern, it means using condense.js, but marijn has no time for the moment to support that).

Controller are not found because it seems that there is an error in the tern plugin angular.js 👍

if (node.type == "FunctionExpression") {

A basic fix, should test if node is not null, but I think we should discover why there is this problem.

Do you think it's possible to share your project which causes this problem?

Thank's

from angularjs-eclipse.

I can share my "test project" which displays similar symptoms, although after clearing my Error Log, I can't get those errors to recur. The tern console also doesn't show any errors, but it still complains about the controller references in the index.html.

How do I attach a file to an issue?

Update:

Hmm. I guess github doesn't provide that capability. That's annoying. What's a reasonable alternative?

from angularjs-eclipse.

Send your project in my gmail account or perhaps you could create a project and push it in your github?

from angularjs-eclipse.

By the way, I noticed that after configuring this, html files were automatically tagged with the AngularJS icon, and they appear to open in the Angular HTML editor. The setup instructions that say you have to override this appear to be obsolete. It appears to be the default without having to set it.

from angularjs-eclipse.

Also, this may not be related, but I noticed that while exploring in the Angular Explorer, very few Angular components were detected in each module. It appeared to find all of my factory objects, but only some of the filters (might want to change the icons used for these two, having one just be a grey version of the other is a little odd, but I think I understand why you did that). it didn't detect any controllers or directives, or anything else.

from angularjs-eclipse.

David, I have fixed your problem with "if (node.type == "FunctionExpression") {". I suggest you to reinstall AngularJS Eclipse and change your script path to "js" folder in order to load your "ui-bootstrap-tpls-0.10.0.js" which declares a lot of directives.

After that when you will open your HTML file, you should see "accordion" attribute in blue and see in Angular Explorer a lot of modules coming from "ui-bootstrap-tpls-0.10.0.js".

With this fix, it is enable to retrieve controllers but not the whole because of your circular dependencies. It's very hard for me to manage that, because I must reevaluate each time the dependencies.

Also, this may not be related, but I noticed that while exploring in the Angular Explorer, very few Angular components were detected in each module.

It's because of your circular reference.

Today "circular" dependencies in module are a limitation with AngularJS Eclipse. I have a lot of work about other issues that I think they are more important than "circular" dependencies which is not a common pattern (according a lot of samples that I have tried).

might want to change the icons used for these two, having one just be a grey version of the other is a little odd, but I think I understand why you did that

Plese give me more suggestions about that (which colors?) or better please provide icons.

from angularjs-eclipse.

Acknowledged. I'll retest. I've concluded that my "circular" arrangement should work, but it's not optimal, so I'll be fixing that today. Please don't remove that from your eventual todo list, but it should be lower priority.

Concerning icons, I'm not qualified to produce icons, but it's clear to me that it would be best to have full color icons for each component type. Let me see if I can find someone in my organization who could do this.

Moving forward, do you have a roadmap for additional features you're planning to implement in the near future? I'm somewhat leading "development life cycle tools" in my organization, and I'd like to give people a view of what this will provide down the road.

from angularjs-eclipse.

Ok, I updated, and I changed my app to have a very small "diagapp.js" and a new "diagMod.js", with the result that I no longer have circular references. Unfortunately, it still says that my controllers are not found. I also found that if I do the crazy step of putting my cursor on the unknown controller name reference and then pressing F3 (Open Declaration), it starts an infinite loop that is only stopped by killing the process (I filed another issue for this).

Do you want me to repackage and re-send you my test project? I did set up my plunkr with the same changes I made in eclipse: http://plnkr.co/edit/RWVUTr450ro8EF2z2afl .

from angularjs-eclipse.

Concerning the icon question, I've talked to some of my UX people, and I've concluded there is no great answer for this. I think perhaps the only choice that is better than the current light-grey "F" is a full-color filter symbol (along the lines of one of these: https://www.google.com/search?q=filter+icon&source=lnms&tbm=isch&sa=X&ei=JSkrU4D_LMKKqgH494C4DQ&ved=0CAkQ_AUoAQ&biw=1097&bih=546). That would mean that all the components except for Filter would be represented by a letter, and this one would be a symbol. However, everyone knows what the conventional filter icon represents. It's an inconsistent strategy, but it's understandable. There is no way someone could know by sight that the full-color "F" represents a Factory and the dull one represents a Filter. It would be better if all the component types had an obvious symbol, instead of the letter. Unfortunately, the names of Angular's component types (controller, directive, et cetera) seem to defy obvious classification into recognizable symbols.

from angularjs-eclipse.

Moving forward, do you have a roadmap for additional features you're planning to implement in the near future? I'm somewhat leading "development life cycle tools" in my organization, and I'd like to give people a view of what this will provide down the road.

To be honnest with you, I develop AngularJS Eclipse in my spare time and I have no roadmap. I think roadmap will be created by issues created. Note that JBoss guys and Nodeclipse guy wishes to integrate AngularJS Eclipse (and so tern IDE). An excadel guy help me too with their contribution.

If you want we can try to organize this roadmap together by creating an issue per need. What do you think about that?

We have planned with my friend pascal to create soon a release.

Please don't remove that from your eventual todo list, but it should be lower priority.

I have created this issue at https://github.com/angelozerr/angularjs-eclipse/issues/39but I'm afraid that it's a complex case.

it starts an infinite loop that is only stopped by killing the process (

Again a problem?

Do you want me to repackage and re-send you my test project? I did set up my plunkr with the same changes I made in eclipse: http://plnkr.co/edit/RWVUTr450ro8EF2z2afl .

Yes if you cand send me your project by mail, it should be cool, because I don't know if we can download project from Plunker.

There is no way someone could know by sight that the full-color "F" represents a Factory and the dull one represents a Filter. It would be better if all the component types had an obvious symbol, instead of the letter. Unfortunately, the names of Angular's component types (controller, directive, et cetera) seem to defy obvious classification into recognizable symbols.

Icons was done quicly by one of my friend. If you think you can provide better icon, don't hesitate to contribute to the project. Thank's.

from angularjs-eclipse.

I've packaged it up, but I just realized that I wasn't looking far enough down the "index.html" file. I saw that it was failing to find the first controller, "DiagCtrl", so I assumed it was behaving the same as before, when it wasn't finding any of the controllers. However, when I just looked closer, I saw that it WAS able to find the "DataSourcesCtrl", even though it couldn't find the "DiagCtrl". I've looked closely at these two controllers and their module definitions, and I don't see anything suspicious.

After I noticed this, I went back to my larger application, and I found that it was still failing to find "DiagCtrl". I looked further down the file, and I found a mix of controllers either being found or not found.

from angularjs-eclipse.

A bit ago I thought to look at both the "index.html" and the Angular Explorer. Even though "DiagCtrl" is marked in the "index.html" in red (unknown controller), when I navigated to "DiagModule" in the explorer, it had "DiagCtrl" in the list, and I could navigate from that into the "DiagCtrl" declaration.

from angularjs-eclipse.

Hi David,

Please reinstall AngularJS Eclipse, I have fixed problem with circular dependencies. In my case I can retrieve your controller and it works with your old and new project.

Tell me if it works for you and if you have not a problem with ndeo.js path.

A bit ago I thought to look at both the "index.html" and the Angular Explorer. Even though "DiagCtrl" is marked in the "index.html" in red (unknown controller), when I navigated to "DiagModule" in the explorer, it had "DiagCtrl" in the list, and I could navigate from that into the "DiagCtrl" declaration.

Tell me if you have again problem with new install.

from angularjs-eclipse.

I updated. I don't see the errors I was seeing before. It still looks like the node.js path is wrong, but since it didn't appear to remove the old version of the file, it's not reporting an error. I added information about this to the other ticket.

I'm seeing a new problem, however. I'll file a new ticket for it if you like. You can even verify this with a small modification to the last project copy I gave you.

Lines 20-21 of the "index.html" should look something like this (How do you quote html in github comments?):

               <div ng-repeat="(name, dataSource) in dataSourceMap">

<!--

-->

In the last copy you have, the first version is commented out, and the second one is commented in. This version above corresponds more closely to my real application. Make this same change in your copy to repeat the problem I'll describe next.

I then looked a few lines down, to this block:

                           <div>
                              {{name}}
                           </div>

I wanted to see how it handled completions, so I put my cursor within the "{{}}" and removed the "name" value and pressed ctrl-space to get the possible completions. The first entry is "(name, dataSource)". This isn't really a valid completion. It should provide both "name" and "dataSource", but not "(name, dataSource)". When I instead tried to enter just "n" and pressed Ctrl-space, it said "No default proposals".

I imagine that "(name, dataSource)" syntax in the ngRepeat is somewhat unusual, but it is legal, and it works fine in my application.

from angularjs-eclipse.

David,

Could you create a new issue with your problem. It's hard for me to see if my fix works or not, because you explain me a new problem each time. Please create an issue per problem. It will be helpful for me and to create a roadmap.

Hope you will understand.

Regards Angelo

from angularjs-eclipse.

I close this issue. Please create a new issue with your last problem. Thank's

from angularjs-eclipse.