Tern->Node.js pref page says "Value must be an existing file" after upgrading plugin about angularjs-eclipse HOT 17 CLOSED

Indeed I have refactored the Node.js path to fill with free path the node.js path for native node.js. Before that it was hard coded with "node". It worked for Windows but not for some other OS. After discussing with JBoss guys about this problem, I have decided to provide a node.js path text field where default node.js path preferences is computed according your OS for native node.js.

This node.js path preferences is used too for embed node.js. So in your case your node.js path was filled for native node.js although you had choosen embed node.js. But this case will never occur if user install the current version of Tern IDE.

That's why I close this issue.

from angularjs-eclipse.

I'm still confused. Isn't this error message going to reoccur every time the user upgrades this plugin? It appears that until I reset this, it was using the wrong executable. It seems like that's going to happen every time I upgrade the plugin.

from angularjs-eclipse.

No this error will not occur when user will upgrade this plugin because node.js path preferences is setted (you have setted this preference, so default preference will not computed).

But perhaps you have found a bug. I suggest you to attach screenshot in order I udensrtand more your problem. Thank's

from angularjs-eclipse.

Well, it's not currently showing "Value must be an existing file" because I've already reset the path by toggling the dropdown twice. My theory was, when I next upgrade the plugin, this will come back, because the path specified in that greyed out field would now point to a nonexistent file. I'll look at this again when you provide the next update, and I'll see if this is still happening.

from angularjs-eclipse.

Ok. After this morning's update I see that it does NOT say "Value must be an existing file", but it still seems like there might be a problem here.

The current setting of the greyed out "Node.js path" field is the following:
C:\eclipse\springsource\sts-3.4.0\sts-3.4.0.RELEASE\plugins\tern.eclipse.ide.server.nodejs.embed.win32.win32.x86_1.0.0.201403201045\node.exe

However, this corresponds to the previous version.

The version that was just installed corresponds to this:
C:\eclipse\springsource\sts-3.4.0\sts-3.4.0.RELEASE\plugins\tern.eclipse.ide.server.nodejs.embed.win32.win32.x86_1.0.0.201403210938\nodejs\node-v0.10.22-win32-x86\node.exe

If the plugin is actually using that value, then it's using the executable from the previous version, which may produce subtle problems.

from angularjs-eclipse.

Ok I understand your fear. But the plugin should not to use the value of node.js path in the greyed out "Node.js path" field but path is computed. So your node.js path will be

C:\eclipse\springsource\sts-3.4.0\sts-3.4.0.RELEASE\plugins\tern.eclipse.ide.server.nodejs.embed.win32.win32.x86_1.0.0.201403210938\nodejs\node-v0.10.22-win32-x86\node.exe

and not

C:\eclipse\springsource\sts-3.4.0\sts-3.4.0.RELEASE\plugins\tern.eclipse.ide.server.nodejs.embed.win32.win32.x86_1.0.0.201403201045\node.exe

in your case. You can check that in the tern console.

But I agree with you, the greyed out "Node.js path" field for embed node.js must display the computed node.js path.

from angularjs-eclipse.

Problem should be fixed. Now node.js path is displayed in a label.

from angularjs-eclipse.

Did you produce another snapshot on the update site for this? The latest version I have has no change on this page.

from angularjs-eclipse.

Build was not done. Please retry it. Next time I suggedt you to see the job https://opensagres.ci.cloudbees.com/job/angularjs-eclipse/ which build the update site

from angularjs-eclipse.

I suggest you consider a different approach. Look at how the m2e (Maven Eclipse) plugin works. In the "Installations" section (instances of Maven), it comes with one installation called "Embedded", that just says what version it is, but it doesn't bother giving a path to that installation, because there's no reason for the user to care what that is. You can also add external installations that refer to file paths. Each row in the table has a checkbox that indicates which installation is used.

If you were to translate this to the Tern section, have a short table that starts with a single entry, called "Embedded". A user can add additional installations, but only one row in the table is selected.

from angularjs-eclipse.

David,

I agree that Node.js preference page could be improved with your suggestion. But I have no time for the moment to improve it. I prefer using my time for other features than this feature. My goal is to execute tern.js and node.js was teh only way that I have found for th emoment to have very good performance. I have provided embed node.js to avoid installing node.js but my goal is not to select your embed node.js. For that you can use the native node.js

But if you wish to improve this preferences page, any contribution are welcome!

from angularjs-eclipse.

I'm not suggesting you make this change now, I'm just recording here what it should look like when time is available.

I don't understand what you mean by "my goal is not to select your embed node.js".

Another problem is that the term "native" doesn't really evoke any meaning. It's clear what "embedded" means, and if the "non-embedded" installation just shows a file path, it's clear that it is not embedded.

I would be glad to make actual contributions and PRs. I'm very far away from getting over the Eclipse plugin SPI learning curve.

from angularjs-eclipse.

I'm not suggesting you make this change now, I'm just recording here what it should look like when time is available.

Yes I had understood that:)

I don't understand what you mean by "my goal is not to select your embed node.js".

I mean that tern ide provides an embed v0.10.22 node.js per OS with the v0.10.22 version. If you wish to use other version, you must install yourself node.js (I have called that native).

Another problem is that the term "native" doesn't really evoke any meaning.
I agree with you. "Installed" terrm is perhaps better?

I would be glad to make actual contributions and PRs. I'm very far away from getting over the Eclipse plugin SPI learning curve.

ok

from angularjs-eclipse.

(What is the best way to quote previous comments?)

I mean that tern ide provides an embed v0.10.22 node.js per OS with the v0.10.22 version. If you wish to use other version, you must install yourself node.js (I have called that native).

    Another problem is that the term "native" doesn't really evoke any meaning.
    I agree with you. "Installed" terrm is perhaps better?

I'm trying to say that the instance that comes with the plugin should be referred to as "embedded". Any others don't need to be "called" anything because they will be represented by a file path. The "embedded" instance won't have a file path.

from angularjs-eclipse.

I've managed to cause this to break again. I've found another reason to avoid hardcoding, even internally, the path to the node executable.

I had been running this with STS 3.4.0. I upgraded to STS 3.5.0 and I imported my preferences from the previous instance.

On the Node.js preference page, My "Node.js install" is set to "Node.js v0.10.22 - win32.win32x86". The "Native path" field is greyed out, but the value points into my old STS 3.4.0 distribution. The "Node.js path" field is just a label, and it points into my STS 3.5.0 distribution. I imagine the "Value must be an existing file" error refers to the nonexistent path of the "Native path" field, which is even sillier, as I'm not even using that value.

from angularjs-eclipse.

David,

The path of "embeded" node.js is not har coded since my last fix.

Please not AngularJS Eclipse was released. Please read https://github.com/angelozerr/angularjs-eclipse/wiki/Installation---Update-Site

from angularjs-eclipse.

The path of "embeded" node.js is not har coded since my last fix.

I don't understand what you're telling me. In my previous comment, I described exactly what I see on the screen after updating to the latest on the 0.1.1-SNAPSHOT update site. Both field values show absolute paths, including the one that doesn't exist.

Please not AngularJS Eclipse was released. Please read https://github.com/angelozerr/angularjs-eclipse/wiki/Installation---Update-Site

Yes, I noticed that. Good to see.

from angularjs-eclipse.