Giter VIP home page Giter VIP logo

Comments (7)

hatsch avatar hatsch commented on July 23, 2024

we also ran into this issue and until an ansible update is out, it renders this otherwise very useful role useless.
i'd suggest to make the versions of the pip packages using variables. so one could at least pin them to a working version.
if you like the idea, i can prepare a patch.

from docker.ubuntu.

angstwad avatar angstwad commented on July 23, 2024

Honestly, I'd like to see something that by default installs the latest docker-py, but allows for optional pinning to prevent this type of issue in the future.

This issue is technically fixed in the devel branch on this issue: ansible/ansible-modules-core#1227 so we shouldn't go crazy trying to fix it in this role.

from docker.ubuntu.

hatsch avatar hatsch commented on July 23, 2024

true, but the defaults for the role could be 'latest' so without interaction everything stays as it is now, but pinning to a specific version becomes an option available.

i know this is fixed in devel, but we run a "stable" version and i'd like to keep that :)
as docker and ansible are both fast moving projects, an incompatibility like that could happen anytime again.

from docker.ubuntu.

angstwad avatar angstwad commented on July 23, 2024

Sure. And I agree, that's what I'd like to see -- by default, install the latest docker-py; allow optional pinning by overriding a default variable.

If you can provide a patch that does this, I'll happily accept it.

from docker.ubuntu.

angstwad avatar angstwad commented on July 23, 2024

This was resolved in PR #41

from docker.ubuntu.

hatsch avatar hatsch commented on July 23, 2024

thanks for merging!

from docker.ubuntu.

PavelVanecek avatar PavelVanecek commented on July 23, 2024

I have discovered this issue and as a complete beginner it was hard to find out what is wrong. So for the future generations coming to see this issue:

The fix is to override the docker_py version in your playbook, like this:

---

- hosts: playground
  roles:
    - role: angstwad.docker_ubuntu
      pip_version_docker_py: 1.1

from docker.ubuntu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.