Giter VIP home page Giter VIP logo

Comments (9)

sonukapoor avatar sonukapoor commented on May 29, 2024 2

@andy-bond yes. 100%. All issues should be fixed. I was just pointing out that this behaviour can be seen through invalid routes. A 404 page would be better.

from angular.

andy-bond avatar andy-bond commented on May 29, 2024 1

I can also reproduce with another link. Also, hi @sonukapoor! :)

I arrived here from: https://angular.dev/guide/i18n/manage-marked-text
Then I clicked on the $localize link near the top of that page.

image

from angular.

sonukapoor avatar sonukapoor commented on May 29, 2024 1

Hey @andy-bond - Good to see you.

Thanks for confirming this.

from angular.

JeanMeche avatar JeanMeche commented on May 29, 2024 1

@andy-bond We're tracking this in #54388 ๐Ÿ‘

from angular.

JeanMeche avatar JeanMeche commented on May 29, 2024

Hi, how did you landed on that page ?

from angular.

sonukapoor avatar sonukapoor commented on May 29, 2024

@JeanMeche Just click the URL provided by @l1337xto

from angular.

JeanMeche avatar JeanMeche commented on May 29, 2024

@sonukapoor I was looking for the page that pointed toward guides/providers, I found none.

from angular.

sonukapoor avatar sonukapoor commented on May 29, 2024

I see what you are saying. All routes that are not matched have this issue, so it's not related to that specific route. I tried a few that don't exist and can see the duplicate sidebar.

from angular.

andy-bond avatar andy-bond commented on May 29, 2024

Sounds good @JeanMeche.

To @sonukapoor's point, it seems like you are mostly concerned with fixing any missing links. But shouldn't the actual "duplicated UI" be investigated? Otherwise won't this same issue re-occur anytime you have a broken link? Wouldn't a "Page Not Found" be more appropriate?

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.