Giter VIP home page Giter VIP logo

Comments (6)

Akxe avatar Akxe commented on June 2, 2024 1

@Akxe I think they just need to redo implementation of cdk overlay how it works and modals. Other stuff should be fine because it's uses cdk overlays.

Indeed, but it means that every API that is using overlay is affected and without workaround

from components.

k3nsei avatar k3nsei commented on June 2, 2024

Yeah we should be embracing web standards here.

from components.

Akxe avatar Akxe commented on June 2, 2024

@wagnermaciel I would argue that this issue is P3 or maybe above since there is no workaround...

  • The dialog API has been stable since 2022, and it does affect all overlays. Meaning that all listed below are affected:
    • Tooltip
    • Overlay
    • Select (menu)
    • Autocomplete
    • Datepicker
    • Menu
    • Sidenav
    • SnackBar
    • and maybe more
  • There is no workaround. If something is using the underlying top layer API, it will always be on top
  • The severity of this issue will grow in time as more libraries and extensions start using these APIs

from components.

k3nsei avatar k3nsei commented on June 2, 2024

@Akxe I think they just need to redo implementation of cdk overlay how it works and modals. Other stuff should be fine because it's uses cdk overlays.

from components.

kbrilla avatar kbrilla commented on June 2, 2024

I say the are not compatible, not completely. For example popover/dialog or more fundamental overlay api has layers, which does not exist on popover api and what’s more will not be implemented. One way could be to move main container of overlay api to top layer to keep existing layer behavior but also keep eveything in one top layer. But then we go into anchor size/position etc… so Ii would rather have new api to work with native popover, and leave css where css is due. Also now that we can create top layer elements from anywhere in dom we don’t need to keep container element and fight with passing data to dialog through injector , have close on router navigation etc.. all that can be done more easily now that dialog/popover can just use native host injectors - of course does not need to, we can still have more similar api to todays one that provide ability to create router independent dialogs. But now we can for example just create those dialogs/popover elements inside root node,not outside it etc. Mayby those two apis should be separate even

from components.

Akxe avatar Akxe commented on June 2, 2024

I say the are not compatible, not completely. For example popover/dialog or more fundamental overlay api has layers, which does not exist on popover api and what’s more will not be implemented.

Do you have an example of component using this behaviour? I am not sure I know of any

The řešit is well thought, well done 😊

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.