Giter VIP home page Giter VIP logo

Comments (4)

psamsotha avatar psamsotha commented on August 20, 2024

I'm having similar problems. The stacktrace is pointing at InMemoryBackendService.parseId

zone.js:355 Unhandled Promise rejection: Cannot read property '0' of undefined ; Zone: angular ; Task: Promise.then ; Value: TypeError: Cannot read property '0' of undefined(…) TypeError: Cannot read property '0' of undefined
    at InMemoryBackendService.parseId 

It seems when the service can't find the collection in the in-memory db, it still tries to parse the id, passing the null collection. And the parseId method doesn't do any null check on the collection argument.

protected handleRequest(req: Request): Observable<Response> {
  const {base, collectionName, id, resourceUrl, query} = this.parseUrl(req.url);
  // collectionName doesn't match anything in the db because it is an external endpoint
  // so `collection` is null
  const collection = this.db[collectionName];
  const reqInfo: RequestInfo = {
    req: req,
    base: base,
    collection: collection,
    collectionName: collectionName,
    headers: new Headers({ 'Content-Type': 'application/json' }),
    id: this.parseId(collection, id),  // pass null collection
    query: query,
    resourceUrl: resourceUrl
  };
}

protected parseId(collection: {id: any}[], id: string): any {
  if (!id) { return null; }
  const isNumberId =  collection[0] && typeof collection[0].id === 'number';  // ERROR!
  if (isNumberId) {
    const idNum = parseFloat(id);
    return isNaN(idNum) ? id : idNum;
  }
  return id;
}

You can simply fix this by null checking the parseId method

protected parseId(collection: {id: any}[], id: string): any {
  if (!collection || !id) { return null; }

From what I tested, this should solve the problem.

Also maybe another thing you may want to consider is the use case of the interceptor method. Currently the algorithm goes

} else if (this.inMemDbService[reqMethodName]) {
  const interceptorArgs: HttpMethodInterceptorArgs = {
    requestInfo: reqInfo,
    db: this.db,
    config: this.config,
    passThruBackend: this.passThruBackend
  };
  return this.inMemDbService[reqMethodName](interceptorArgs);
} else if (reqInfo.collection) {
  return this.collectionHandler(reqInfo);
} else if (this.passThruBackend) {
  return this.passThruBackend.createConnection(req).response;
}

If there is an interceptor method, the interceptor method still gets called, passing the invalid request info. Maybe you should also check for the presence of a collection

} else if (this.inMemDbService[reqMethodName] && reqInfo.collection) {

from in-memory-web-api.

kevin-madhu avatar kevin-madhu commented on August 20, 2024

@psamsotha If you've got the fix, could you please correct it and try sending a PR?

from in-memory-web-api.

wardbell avatar wardbell commented on August 20, 2024

Thanks!

I agree with the parseId check. But the method interceptor should be called without regard to the reqInfo.collection. In fact, it would be wrong to care because the interceptor is often needed when there is no collection. I'll merge the partial as part of PR #36 which I'm working on now.

Update

The one approved change was merged with PR #39

from in-memory-web-api.

psamsotha avatar psamsotha commented on August 20, 2024

@wardbell Thanks. I guess I was not sure as to the real purpose of the interceptor method :-)

from in-memory-web-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.