Giter VIP home page Giter VIP logo

Comments (5)

EisenbergEffect avatar EisenbergEffect commented on May 9, 2024

I can easily tag the latest version of the router. It's solid. Now would be
a good time since I'll probably be adding new features again soon. How
should we label the tags?

On Sun, Aug 3, 2014 at 1:35 PM, Caitlin Potter [email protected]
wrote:

So, it's been about 5 months since the last "dist" release was updated,
and there are almost no tagged releases yet.

@EisenbergEffect https://github.com/EisenbergEffect / @tbosch
https://github.com/tbosch do you think you guys could pick out some
suitably stable commits for tagging so that prototypes can be built against
relatively recent changes to the code? Not necessarily the bleeding edge,
but just stable "enough" to be useful, I guess.


Reply to this email directly or view it on GitHub
#39.

Rob Eisenberg,
President - Blue Spire
www.durandaljs.com

from templating.

caitp avatar caitp commented on May 9, 2024

My vote is to tag the dist builds as v<semver>-dist, and the non-dist builds as v<semver> --- although, I think we should only be publishing the dist builds on npm (which is another issue).

from templating.

tbosch avatar tbosch commented on May 9, 2024

Hi,
I would not tag the individual projects templating/router in the current development stage, but use the already existing dist branch in the angular/projects project that also contains all of the dependencies like es5-shim.

Reasons:

  • the V2 projects templating and router always use the master version of each other and also of di.js, and rebuild them in their build (so they don't use the dist branches). This is good as it makes changes and refactorings in our current stage of development easier. If we would tag one project (say router) then we would also need to tell people (or our demo :-) ) which tag of the other projects they should use with it. However, as they projects themselves don't contain tags in their dependencies, we would actually need tag every dependency of a project when we tag (and tested) that project.
  • to know whether the current code or a project is actually working with the other projects we only have the e2e tests in angular/projects right now. So when tagging one project we already need to build angular/projects with the current master branches of every V2 project.

The only open point for this: the build for angular/projects is not triggered yet by a change of a dependent project. However, we can fix this by adding a BUILDNUMBER file to it that we increment whenever we need a new build.

So to summarize:

from templating.

tbosch avatar tbosch commented on May 9, 2024

Hi,
I made the following changes:

  • remove the dist branch from templating (there was none for router yet)
  • add FORCE_BUILD file to angular/projects
  • change the travis build of angular/projects to also tag the dist branch

To create a new version when a dependency changes, just change the FORCE_BUILD file in angular/projects, wait for the travis build and use the created tag.

Here is the first automatically created tag: https://github.com/angular/projects/releases/tag/dist-630ea91

BTW: Using angular/projects we are also able to create plunkers (although with ES5 and not ES6 though). The following is a todo plunker for templating that uses a concrete label of angular/projects dist branch: http://plnkr.co/edit/0Gq3IK8Mj5DtBtmzW8gT?p=preview

from templating.

tbosch avatar tbosch commented on May 9, 2024

Just realized that if we tag every commit, we can also just use the commit as tag :-)
So changed the build script back to not adding tags, but left the FORCE_BUILD file in the project to force a build.

from templating.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.