Giter VIP home page Giter VIP logo

Comments (8)

vn-ki avatar vn-ki commented on August 26, 2024 1

@enderlein Even though you have push access to the repository, it's better to open a PR, unless it's a very minor change. I'll do the same too, because another pair of eyes is always better.

from anime-downloader.

KashTag avatar KashTag commented on August 26, 2024

I can't really understand which file you're trying to delete (noob here :P) but I found out there's a function 'remove(file path)' in the module 'os' that can delete files.
If you want I could try it out but you'll have to tell me which file you exactly want deleted and when, though I can't guarantee anything cause i'm still pretty crappy at python.

from anime-downloader.

KashTag avatar KashTag commented on August 26, 2024

Hmm are you saying that the watch.json file should be deleted when the command anime watch -l is entered?

from anime-downloader.

vn-ki avatar vn-ki commented on August 26, 2024

I think we shouldn't remove any file. We can catch the unicode error and do raise a more informational error. I think that is not required because the only people using watch would be us 3, and all installs after 2.6.0 would use json by default.

from anime-downloader.

enderlein avatar enderlein commented on August 26, 2024

That would make a lot more sense. I'll work on doing that.

from anime-downloader.

enderlein avatar enderlein commented on August 26, 2024

Of course.

from anime-downloader.

enderlein avatar enderlein commented on August 26, 2024

Ah never mind, I've changed my mind. The only 3 people who need to be worried about this are already informed about it and I already deleted the old file so I can't properly test anything new.

from anime-downloader.

vn-ki avatar vn-ki commented on August 26, 2024

Haha. Okay then.

from anime-downloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.