Giter VIP home page Giter VIP logo

Comments (6)

drastik avatar drastik commented on May 25, 2024

@ankitpokhrel @samundra

Do you guys have any thoughts here?
It would be great if Symfony were to fully implement HEAD requests, but there have been many arguments for it in the past, and they were all shot down. I don't know what the chances are of Symfony doing so, but I put in the feature request regardless.

from tus-php.

samundra avatar samundra commented on May 25, 2024

Changing HEAD request to GET is definitely not desired. However, lets verify the changes needed for HEAD request to implement it in Symfony Request/Response. But we have to identify its impact on the project. Waiting for thoughts from @ankitpokhrel

from tus-php.

ankitpokhrel avatar ankitpokhrel commented on May 25, 2024

File download in GET /files/<hash> request is not a part of the tus specification. I would propose to move current file download endpoint to GET /files/<hash>/get and treat GET /files/<hash> same as HEAD request.

One thing to note here is that official tus server implementation treats GET /files/<hash> request as file download request.

I am open for other ideas.

from tus-php.

drastik avatar drastik commented on May 25, 2024

I love the idea of adding /get or any other path component to indicate download.

I've not seen any traction in Symfony or Drupal camps to implement HEAD, I'm surprised it has gone this way for years, but no one had a valid use case.

from tus-php.

samundra avatar samundra commented on May 25, 2024

@ankitpokhrel I think we should try to implement what current tus-servers have implemented for the download request.

The solution that you proposed could work as custom solution for download extending on top of official tus server implementation.

I think we should implement the custom solution that are already in use by most tus-servers.

from tus-php.

ankitpokhrel avatar ankitpokhrel commented on May 25, 2024

Changed in #87

from tus-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.