Padding for gnome-terminal about flatabulous HOT 8 OPEN

I agree with you! Looks really good! The padding is broken, almost everywhere! I am also considering some global padding? What are your thoughts on that?

from flatabulous.

Global padding is a bad idea. Elements mostly has their own padding/margin, so there's no reasons to add it globally.

from flatabulous.

I agree with you on the gobal padding. I tried it, and it broke all the apps. Let's do the 5px 10px padding 👍

I am also going to replace the png assets with svg, so that the theme scales well on a HDPi monitor, which is again my concern, if the padding will be enough on those screens? I don't have a screen around to test, however I would like if somebody could comment on that.

from flatabulous.

@vooze Would be great if you could provide some input?

from flatabulous.

@anmoljagetia To be honest padding have never bothered me in a terminal, but I can see it looks just fine. But maybe 10 is a bit too much?

Regarding High DPI, I think it should be just fine. Since gnome really only does x2 scaling good. So I would guess it would just double it for high DPI.

from flatabulous.

Yeah, 8 could be nice. Because I am using the Hack font for terminal, and it has less line height, so 10 does look a bit too much.

@Defman21 I think you are using Source Code Pro? Which has a higher line height, so 10 seems more appropriate. I would like to get your input on that. Let's set it at 8px or 10px ?

from flatabulous.

I'm using Hack at 12pt. My text scaling factor is 0.94 (90DPI). I don't really care about 8px or 10px, 2px is a very little value so I don't see much difference in these, but @vooze point seems fair, so I'd prefer 8px over 10px. But top/bottom should be 5px, there are no reasons to have bigger padding for top and bottom, it looks not good imo.

from flatabulous.

@Defman21 Agreed!

from flatabulous.