Giter VIP home page Giter VIP logo

Comments (4)

yito88 avatar yito88 commented on August 15, 2024 1

It seems that NaN canonicalization is already set when Singlepass is created.
https://github.com/heliaxdev/anoma-prototype/blob/e1023fe30dc4cbd928ab05b9e9c0c3f099369a2c/ledger/src/bin/anoma-node/vm/mod.rs#L127
In the default configuration, enable_nan_canonicalization is set true.
https://docs.rs/wasmer-compiler-singlepass/1.0.2/src/wasmer_compiler_singlepass/config.rs.html#20-26

from anoma-archive.

tzemanovic avatar tzemanovic commented on August 15, 2024 1

Another thing we might need to check here is that wasm code doesn't use any internal memory other than what it can get from the host environment. We can also check the module's imports such as the host env functions signatures.

from anoma-archive.

cwgoes avatar cwgoes commented on August 15, 2024

We want to avoid any non-deterministic behaviour and anything which cannot be appropriately (safely) gas-metered.

from anoma-archive.

tzemanovic avatar tzemanovic commented on August 15, 2024

Let's also remember to review the WasmFeatures that we've added in #110, for which we chose the most restrictive options for now for safety.

from anoma-archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.