Making indic-nlp-library available via Conda Forge about indic_nlp_library HOT 4 OPEN

@anoopkunchukuttan I am unable to make this available in Conda Forge because your setup.py script is improperly configured: it does not include the version.txt file, even though this is required by the script itself. In order for the package to include this file, I believe you have to pass this argument to setuptools.setup in setup.py:

package_data={'indicnlp': ['version.txt']}

Otherwise, when you run setup.py from the PIP-downloaded package, it will fail to find version.txt and thus the setup script will abort.

Can you make this change? Or will you accept a PR if I submit one for this? Thank you.

from indic_nlp_library.

I have submitted a PR for this here: #64

from indic_nlp_library.

Sorry for the delay @Ubadub

• You can add me as the recipe maintainer.
• There is already a version.txt inside the indicnlp directory, and version info is passed in as parameter to the setup function.

Let me know if that works, or package_data needs to be set as you mention.

from indic_nlp_library.

Thanks for your reply.

There is already a version.txt inside the indicnlp directory, and version info is passed in as parameter to the setup function.

The version.txt file is not bundled with the pip package, because pip only bundles .py files by default, and so when the source files are downloaded by Conda, it is not included. Thus, when conda executes the setup.py script, it results in an error, because the file is not there. In this PR, I have made the appropriate change so that the version.txt file does get bundled with the pip package.

Does that make sense? You can check this for yourself by running python setup.py sdist. You will notice that the resultant folder does not contain version.txt.

Let me know if you have any other questions.

from indic_nlp_library.