Giter VIP home page Giter VIP logo

Comments (11)

anosorae avatar anosorae commented on July 24, 2024

Please give a more detailed evidence to prove your claim.

from irra.

lzfff12 avatar lzfff12 commented on July 24, 2024

image
The caption_tokens in the diagram are a list that is passed directly to the function, and if the value in the function changes, the value in the list will also change

from irra.

lzfff12 avatar lzfff12 commented on July 24, 2024

We also confirmed this by printing

from irra.

anosorae avatar anosorae commented on July 24, 2024

I have confirmed the issue you mentioned, which was caused by an oversight in my code writing, and I am evaluating the impact of this issue on the final retrieval results.

Anyway, thank you for pointing this out, I will provide more explanation after the evaluation.

from irra.

lzfff12 avatar lzfff12 commented on July 24, 2024

OK,thanks

from irra.

Zplusdragon avatar Zplusdragon commented on July 24, 2024

The two list share the same memory. This may be the reason. Turning to use deepcopy will solve it. However, will it affect the performance?

from irra.

anosorae avatar anosorae commented on July 24, 2024

When I changed the shallow copy to a deep copy, i.e. calculating the SDM loss between image feature and masked text feature, there was some performance loss. Here are the results:

task R1 R5 R10 mAP mINP
t2i 71.069 87.606 92.122 64.879 50.267

And when I calculate the SDM loss bwtween image feature and masked text feature and text feature, the performance loss is lower:

task R1 R5 R10 mAP mINP
t2i 72.840 88.678 93.324 65.407 49.512

From my point of view, I think the question raised in this issue about using a shallow copy and not a deep copy is equivalent to the fact that I have applied an augmentation to the input text, similar to the data augmentation done to the input image. This leads to a difference in the final result. But it does not affect the conclusions of the paper.
Thank you for your attention to our work, I hope that my response will satisfy you.

from irra.

lzfff12 avatar lzfff12 commented on July 24, 2024

Is the result of the above table under the setting of id+mlm+sdm?

from irra.

anosorae avatar anosorae commented on July 24, 2024

Yes. @lzfff12

from irra.

Zplusdragon avatar Zplusdragon commented on July 24, 2024

In the build_random_masked_tokens_and_labels function, there is no deepcopy operation on caption_tokens to get the mlm_tokens. And this will make the two tokens completely same. It means the caption_tokens using for calculating SDM_loss are also masked. But in the paper, it uses unmasked caption_tokens to calculate it. Maybe is it a bug?

from irra.

anosorae avatar anosorae commented on July 24, 2024

@Zplusdragon When I was writing the code, I thought the .numpy() function would convert from tensor to a new ndarray, not realising that the two would actually share memory. So, you could say it's a bug.

from irra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.