Python 3 Support about openrtb HOT 4 CLOSED

I'll see what I can do. Shouldn't be hard.

from openrtb.

Thanks, I run 2to3 and it seems to work, only one test failing:

class TestFields(unittest.TestCase):
    ...
    def test_bad_utf8(self):
        self.assertEqual(openrtb.base.String('x\xff'), 'x')

which I guess it's because 2to3 changes unicode to str so the following function (result of running 2to3 to base.py) doesn't work correctly:

def String(value):
    if isinstance(value, str):
        return value
    if isinstance(value, str):
        return value.decode('utf-8', errors='ignore')

    return str(value)

I was wondering if there are any issues with encoding and the RTB protocol which python3 might brake.

Cheers!

from openrtb.

the "hardest" part will be dealing with the ObjectMeta class. So six will probably have to be added as a dependency.

from openrtb.

Resolved by merging #17

from openrtb.