Comments (8)
@briantist Thank you for reporting this! We have recently this module to our CI so it should be easier to add a test case for this.
from community.aws.
If that's what happens on first creation, then that's what should happen after first creation as well imo to maintain idempotence. I'll work on that and add some integration tests to validate
from community.aws.
Files identified in the description:
If these files are inaccurate, please update the component name
section of the description or use the !component
bot command.
from community.aws.
cc @jillr @s-hertel @tremble @wimnat
click here for bot help
from community.aws.
I'm not sure if this is reproducible outside of a VPC since I'm not sure there is such a thing as a default SG in that case.
imo you can create ALB resources only in a VPC.
the only way to solve this issue is imo to not allow an empty array as an input for security_groups
parameter.
otherwise and empty array must be treated as "use the VPCs default security group", which must be determined inside the code.
from community.aws.
I believe that "use the default VPC SG" is a desirable option in some/many use cases, so I wouldn't want to see that option disappear. It would be most useful if the module handled that case correctly, even if internally it means it has to retrieve the VPC default in order to verify its state.
from community.aws.
I can work on this @briantist @markuman. Expected behavior is treat empty array as "use the VPCs default security group" ?
from community.aws.
I can work on this @briantist @markuman. Expected behavior is treat empty array as "use the VPCs default security group" ?
@jatorcasso kind of yes, that's already what happens on first creation; the problem is that running it again will fail. So when the ALB already exists, the module needs to have a way to verify the current state, and that part is not working now. It may require reading the default SG from the VPC in order to verify.
It might also be desirable to have "use the default VPC" as a separate option and then disallow the empty SG list, not sure...
I might also suggest that no security group option supplied, when the ALB exists, might mean "don't check or change the state of SGs" but that is a behavioral change.
from community.aws.
Related Issues (20)
- Add Lookup for Get Random Password HOT 1
- s3settings sample not found [community.aws.dms_endpoint]
- Indentation inconsistent on cloudfront_distribution module
- aws_api_gateway only creates REST-API and not HTTP
- Integration tests need to be updated to avoid unsafe templating HOT 1
- Add support for "skip_matching" preference in autoscaling_instance_refresh
- Typo in autoscaling_instance_refresh module in check mode HOT 1
- Unable to connect with SSM on Amazon Linux 2023 based instances HOT 6
- Allow bulk deletion of ECS Task Definitions HOT 1
- etag module util missing unit tests
- Implement Support for Amazon EFS Archive Storage Class and Elastic Mode in Ansible EFS Module
- aws workspaces inventory plugin HOT 1
- SSM Connection: Failed to create temporary directory HOT 2
- Add possibility to create AWS Network Load Balancer with attached Security Group
- Add throughput mode elastic for efs HOT 1
- api_gateway doesn't create a new deployment when API Gateway already exists
- eks_cluster should be able to upgrade cluster versions
- aws_ssm remote directory / HOT 4
- Add task to get a list of all ECS clusters HOT 2
- s3_lifecycle module should allow setting the ChecksumAlgorithm argument to AWS SDK put_bucket_lifecycle_configuration() call
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from community.aws.