vmware_dvswitch_lacp, map vmnic to lag about community.vmware HOT 9 CLOSED

Files identified in the description:

• plugins/modules/vmware_dvswitch_lacp.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

from community.vmware.

cc @Tomorrow9 @goneri @lparkes @pgbidkar @warthog9
click here for bot help

from community.vmware.

I would like to have this feature as well.
But should it not be handled by vmware_dvs_host. Just add an uplink to the vmnic (lag-0, lag-1) and if nothing defined, just use the default (Uplink 1, Uplink 2)

from community.vmware.

@Aglidic I'm not sure I understand this issue. Could you please explain what exactly you have to do manually?

@noesberger

But should it not be handled by vmware_dvs_host.

I'm not sure since I don't understand the problem here. But I agree with you, assigning physical NICs of an ESXi hosts to LAG uplinks looks like a job for vmware_dvs_host to me. For example, you might want (or have) to use vmnic0 and vmnic2 for lag-0 and lag-1 on one host, but vmnic1 and vmnic3 on another. So that's clearly something that's host specific and can't be done on the LAG level.

Just add an uplink to the vmnic (lag-0, lag-1) and if nothing defined, just use the default (Uplink 1, Uplink 2)

I'm not sure if a lot of people are doing this, but as far as I know you can have more than just one LAG on a virtual switch. If I understand your proposal correct, we couldn't support this. I haven't put much thought into this but what do you think about something like this:

vmnic:
    - vmnic0
    - vmnic1
lag_uplinks:
    - lag: foo
      vmnic:
          - vmnic2
          - vmnic3
    - lag: bar
      vmnic:
          - vmnic4
          - vmnic5

What do you think? I'm not really sure myself, I've just thought that up on the spur of the moment.

from community.vmware.

Hi, I am also interested in this. It is exactly as @mariolenz explained. When using 'community.vmware.vmware_dvs_host' module to add host vmnics to DVSwitch, they are added as plain uplink ports. There is no possibility to add them to a already created LAG uplink port. This would be perfect:

vmnic:
    - vmnic0
    - vmnic1
lag_uplinks:
    - lag: foo
      vmnic:
          - vmnic2
          - vmnic3
    - lag: bar
      vmnic:
          - vmnic4
          - vmnic5

from community.vmware.

Sorry @miguelgmedina but this turned out to be trickier to implement than I originally expected. I think I'm making some progress, but only slowly.

from community.vmware.

For the record: vmware/pyvmomi-community-samples#457

from community.vmware.

@noesberger @miguelgmedina #903 is still labeled as work in progress because I want to add an example and test cases, and I also have to update the documentation. But feel free to test it, I'm quite sure the code works.

from community.vmware.

@Aglidic @noesberger @miguelgmedina @tkelkermans Now that I added an example and test cases (and also tried to improve the quality of my code a bit) I don't consider #903 work in progress any more. Would be great if you could test this PR and tell me if it works for you :-)

from community.vmware.