daft.search() returns number of results on page, not number of search results about daftlistings HOT 5 CLOSED

Hi @sdfordham, good spot. I think that print should be removed. In terms of getting the total number of properties, I'm thinking the regex method would be the quickest way to get the total number rather than having to iterate over each page to get the total count.

from daftlistings.

I added a new method search_count to the Daft class that returns the total number of properties.

Example usage:

from daftlistings import Daft, RentType

daft = Daft()
daft.set_listing_type(RentType.APARTMENT_TO_SHARE)

listings = daft.search()

print(daft.search_count)

from daftlistings.

I guess I was indirectly considering the following: if a user does listings = daft.search() then what should the result of that be? At the moment it puts 20 results into listings (or however many appear on page 1 of the search) but that seems kinda arbitrary. Should listings = daft.search() get back all the results into listings?

from daftlistings.

@sdfordham, you can use the offset method to increment the page number and iterate over each page. Having the search_count allows you to work out what that offset should be. However, I do like the idea of having the search method automatically get all listings. Perhaps this could be added as an optional param to the search method i.e (search(fetch_all=True)?

from daftlistings.

I'll close this issue and use #62 for further discussion.

from daftlistings.