Giter VIP home page Giter VIP logo

Comments (4)

baizon avatar baizon commented on July 22, 2024

Have you set your Additional player parameters to this: --ytdl-format=best
Or try this in your terminal: $ mpv https://www.youtube.com/watch?v=lx_vWkv50uk --ytdl-format=best

from mpv-youtube-dl-binding.

tkoehlmann avatar tkoehlmann commented on July 22, 2024

mpv https://www.youtube.com/watch?v=lx_vWkv50uk --ytdl-format=best

Works fine. Setting the additional parameters to --ytdl-format=best didn't change anything.

from mpv-youtube-dl-binding.

tkoehlmann avatar tkoehlmann commented on July 22, 2024

Feel free to close this "issue".

I fiddled around a bit and let the addon call a shell script that I wrote which dumps some stuff into a log file. That's the script here:
LOG=~/notmpv.log
echo "$*" > $LOG
echo "PATH = $PATH" >> $LOG
mpv $* >> $LOG

One of the messages I got was [ytdl_hook] youtube-dl not found, not executable, or broken. I don't have youtube-dl installed system wide, but in ~/bin, which is added to the $PATH in my .bashrc. When I'm on the terminal the path is fine. For some weird reason it is not when calling the script (and thus also not when pressing the button in Firefox). So the problem is absolutely not in your excellent addon but somewhere either in Firefox, Gnome or whereever.

Regards

from mpv-youtube-dl-binding.

tkoehlmann avatar tkoehlmann commented on July 22, 2024

In case anyone else has this problem: I figured out what is going on. Apparently GNOME 3 doesn't actually source the rc file of the login shell (not bashrc, not bash_login, not bash_profile).

The PATH needs to be set in ~/.profile for GNOME 3 to actually read and apply it.

from mpv-youtube-dl-binding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.