Combine 2 arrays about expr HOT 13 CLOSED

Not sure if this deserves its own issue but I found myself wanting a way to merge maps as well. I've used Python's dictionary unions like this before.

from expr.

Added!

from expr.

Right now Expr doesn't have a built-in concat function.

But it can be easily added via expr.Function

from expr.

Sure @antonmedv, but I think its commonly enough to add it here as well

from expr.

What should we add? append() or concat()? :)

from expr.

I think concat() would make more sense here, since append would only add the array as a new entry:
concat:

array1 = [1, 2, 3]
array2 = [4, 5, 6]
array3 = concat(array1, array2) -> [1, 2, 3, 4, 5, 6]

Append would be:

array1 = [1, 2, 3]
array2 = [4, 5, 6]
array3 = append(array1, array2) -> [1, 2, 3, [4, 5, 6]]

from expr.

Hmm just checked it for go. It seems different here xD

package main

import (
    "fmt"
)

func main() {
    slice1 := []int{1, 2, 3}
    slice2 := []int{4, 5, 6}

    // Concatenating slice1 and slice2
    concatenatedSlice := append(slice1, slice2...)

    fmt.Println(concatenatedSlice) // Output: [1 2 3 4 5 6]
}

from expr.

Ok append it is :) I still think that concat is the better function name, but could be bias.

from expr.

I like concat()?

from expr.

I also think concat() is the better wording for that.

from expr.

I love JS, so will vote for concat(). And one element can be wrapped in array.

from expr.

I think with slices.Concat added in Golang 1.22(to merge to slices), the name should be concat

from expr.

So it will be concat

from expr.