Giter VIP home page Giter VIP logo

Comments (5)

tsoulabail avatar tsoulabail commented on June 26, 2024 2

In 2023, the first work was to push pg14 and pg15, as quickly as possible, with in background "the backward compatibility ".
I think that your proposal to cleanup is what needs to be done.
I like the idea postgresql_vacuum_cost_page_miss: "{{ 2 if postgresql_version is version_compare('14', '>=') else 10 }}"

from postgresql.

MrMegaNova avatar MrMegaNova commented on June 26, 2024

Hi @conscribtor , Thanks for your work. I think this change need more discussions, but i definitively think that you should ensure backward compatibility. We doesn't provide default configuration template for many reasons, most of them I don't know very well but you can check on olders PR / issues. People here can certainly give you much more information about the reasons of all theses changes. As you probably seen on our recent changes, we don't test pg =< 10 anymore.
@tsoulabail Can you give us your opinion about this ?

from postgresql.

conscribtor avatar conscribtor commented on June 26, 2024

Adding a new PostgreSQL version might be a good opportunity to fix those defaults. There might be ways to include them while remaining backwards compatible.

One possibility might be to version_compare('16', '>=') them, but use the annotations to reflect when they were originally changed upstream:

postgresql_vacuum_cost_page_miss:  "{{ 2 if postgresql_version is version_compare('16', '>=') else 10 }}" # (<= 13: 10, >= 14: 2) 0-10000 credits

Let me know what you think, if i should proceed with that idea and which I should include in that way.

from postgresql.

conscribtor avatar conscribtor commented on June 26, 2024

In 2023, the first work was to push pg14 and pg15, as quickly as possible, with in background "the backward compatibility ". I think that your proposal to cleanup is what needs to be done. I like the idea postgresql_vacuum_cost_page_miss: "{{ 2 if postgresql_version is version_compare('14', '>=') else 10 }}"

Thank you - I've pushed the new defaults using this pattern in 5562199.

from postgresql.

MrMegaNova avatar MrMegaNova commented on June 26, 2024

I close this issue, work can be seen in #564

from postgresql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.