Giter VIP home page Giter VIP logo

Comments (9)

richardfsr avatar richardfsr commented on May 22, 2024 1

That's great, thanks for that! Confirmed that it works out of the box in my project now.

from wallet-adapter.

richardfsr avatar richardfsr commented on May 22, 2024 1

It works without any problems :)

Just on signMessage it's supported by Sollet too https://github.com/project-serum/sol-wallet-adapter/blob/master/src/index.ts#L188 any chance of including it?

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

Hmm, good question. It looks like it's failing to parse this "esnext" syntax. Did you use a particular template or configuration for create-react-app? I'll try to reproduce this today.

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

I think the issue is that create-react-app doesn't process files in the node_modules directory, and this library doesn't transpile from TypeScript to ES5. https://stackoverflow.com/a/64785265 has a reasonable solution using craco to be able to configure babel without ejecting your create-react-app project.

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

@Richard-Fisher I changed the TypeScript build target in the project from esnext to es6. It should work out of the box in modern browsers.

I also added a starter project using CRA, also with a TS target of es6: @solana/wallet-adapter-material-ui-starter

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

Unfortunately this change broke tree shaking, causing #69

I've changed the module type back to esnext @ 6d9c3a7

However, the starter projects using CRA and Next.js still work by transpiling these modules.

@Richard-Fisher please let me know if you need some additional configuration to support Babel specifically, and I'll add it to this FAQ

from wallet-adapter.

richardfsr avatar richardfsr commented on May 22, 2024

I ended up creating a fork because I needed signMessage but I think you have added this now as an optional interface?

I'll switch back to this repo and do some tests and let you know, thanks!

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

Awesome, I appreciate that. Thank you!

from wallet-adapter.

jordaaash avatar jordaaash commented on May 22, 2024

Sure, please open an issue -- or PR if you use that! It should be very simple to implement using Phantom as a template.

from wallet-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.