Feature Request: Add linebreaks between END and START about aoe_templatehints HOT 8 CLOSED

Could you please check, if this fixes it for you?

from aoe_templatehints.

Gives

Parse error: syntax error, unexpected '.' in /Users/winkelsdorf/sites/magento191.dev/app/code/community/Aoe/TemplateHints/Model/Renderer/Comment.php on line 31

Need to remove either the last point in 31 or 1st in 32.

Tested with fixed dot, looks way better 👍

Just the nested blocks are created like this

 --><!-- [START: 20] catalog.topnav

But that's ok for me. The main issue was missing some START/END blocks, that's solved now.

Edit: Don't forget to back merge your repo to keep sync with master. I usually follow the guideline from SO (http://stackoverflow.com/questions/7244321/how-to-update-github-forked-repository).

from aoe_templatehints.

Argh, sorry. Stupid mistake :) Try it like this, please.

from aoe_templatehints.

Nevermind, In my own repo I made a mess yesterday too, due to too early commits and small typos 😂

Looks way better! Just after the start block, right before the content (see bottom of the screenshot) needs one more linebreak probably? But we are both very pedantic about 😆

In line 29 of your code:

   '<!-- [START: %1$s] %4$s'."\n".'%5$s -->'.  "\n".

Edit: Yes, that works. Just add the \n there too :)

from aoe_templatehints.

How we doing now? I added another linebreak before the [END] too (just for good measure)

from aoe_templatehints.

Just tested, works perfectly fine and it's very readable now. Thank you 👍

Hopefully this patch makes it into the master repo :)

from aoe_templatehints.

Merged into master. Thank you for contributing and testing this!

from aoe_templatehints.

You're welcome, Thank you both too!

from aoe_templatehints.