Giter VIP home page Giter VIP logo

Comments (4)

liferoad avatar liferoad commented on June 11, 2024 1

I like your idea. Thanks for opening this issue.

from beam.

Abacn avatar Abacn commented on June 11, 2024

filesystem extensions [gcp],[s3],etc are optional dependencies of beam. #31219 will cause excessive warning raised if user not intended to install these dependencies. Can we improve the error message you referred in the description instead?

Unable to get filesystem from specified path, please use the correct path or ensure the required dependency is installed, e.g., pip install apache-beam[gcp]. Path specified: ...

to, e.g.

Unable to get filesystem of scheme "s3://" from specified path

from beam.

Abacn avatar Abacn commented on June 11, 2024

Even better, currently it hints 'e.g., pip install apache-beam[gcp]. If the failed scheme is gs://, we can hint user to do pip install apache-beam[gcp]; if the failed scheme is s3://, we can hint user to do pip install apache-beam[aws]; and so on

from beam.

RyuSA avatar RyuSA commented on June 11, 2024

@Abacn Thank you for reviewing my proposal. 👍

#31219 will cause excessive warning raised if user not intended to install these dependencies...

In my PR, there should not be any warning logs for modules ([gcp], [aws], etc.) that the user has not intended to installed. The import statement for not-installed modules should throw ModuleNotFoundError, so they should be blocked before the section on ImportError. (Am I right?)

$ python3
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> try:
...   import this_is_module_not_found
... except ModuleNotFoundError:
...   print("ModuleNotFound!")
... except ImportError:
...   print("ImportError!")
... 
ModuleNotFound!
>>>

However, on the other hand:

Can we improve the error message you referred to in the description instead?

Even better, currently it hints ...

I think these ideas are excellent!

I was considering this issue under the scope of "when modules (gcp/aws/azure) installed by the user as Filesystem fail to initialize due to for some reason (such as OpenSSL)."
I think the enhancement you suggested(where the user has not installed Filesystem) could either be a separate issue or included in this one. (I would be happy to submit a PR! 👀)

from beam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.