Giter VIP home page Giter VIP logo

Comments (4)

PokIsemaine avatar PokIsemaine commented on June 18, 2024 1

If convenient, you can add other checks at the same time, such as golang format, clang tidy

from kvrocks.

JoverZhang avatar JoverZhang commented on June 18, 2024

I guess we could hard link pre-push.sh to .git/hooks/pre-push during x.py build.

For example:

https://github.com/rust-lang/rust/blob/faefc618cf48bd794cbc808448df1bf3f59f36af/src/bootstrap/src/core/build_steps/setup.rs#L511-L522

However, I'm unsure about the directory in the project where the pre-push.sh source code should be placed.

from kvrocks.

mapleFU avatar mapleFU commented on June 18, 2024

However, I'm unsure about the directory in the project where the pre-push.sh source code should be placed.

At root or some build scripts might be ok

clang tidy

clang-tidy is time-consuming, I guess puting it at ci or by-user is better

from kvrocks.

PokIsemaine avatar PokIsemaine commented on June 18, 2024

/assign

from kvrocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.