Giter VIP home page Giter VIP logo

Comments (7)

spangaer avatar spangaer commented on August 15, 2024 1

Could I argue that the "commands" used to make these changes, that result in "massive commits", should be checked in as a script in a commit before the actual rename, so that:

  1. The script can be reviewed instead of the change
  2. The script can be applied to check that the rename commit result matches the script execution

from pekko.

mdedetrich avatar mdedetrich commented on August 15, 2024

@pjfanning Since #20 is abandoned, are you going to recreate it or should I? I was also thinking of rather than renaming the modules from akka-* to pekko-* (i.e. akka-actor to pekko-actor) that instead we should just have the module name without pekko (i.e. akka-actor would just become actor).

The reasoning is the same as renaming akka-docs to just docs, i.e. its extra/unneeded noise and its also not consistent with the other pekko repo's (i.e. alpakka doesn't have akka- prefix for each of their sbt modules). Since we are renaming the sbt modules anyways there isn't going to be any extra noise, only thing we need to do is to make sure to add the pekko- prefix in the generated jar which is quite easy.

Should also do this after #35 gets merged so as to not deal with a lot of merge conflicts.

from pekko.

pjfanning avatar pjfanning commented on August 15, 2024

@pjfanning Since #20 is abandoned, are you going to recreate it or should I? I was also thinking of rather than renaming the modules from akka-* to pekko-* (i.e. akka-actor to pekko-actor) that instead we should just have the module name without pekko (i.e. akka-actor would just become actor).

The reasoning is the same as renaming akka-docs to just docs, i.e. its extra/unneeded noise and its also not consistent with the other pekko repo's (i.e. alpakka doesn't have akka- prefix for each of their sbt modules). Since we are renaming the sbt modules anyways there isn't going to be any extra noise, only thing we need to do is to make sure to add the pekko- prefix in the generated jar which is quite easy.

Should also do this after #35 gets merged so as to not deal with a lot of merge conflicts.

I'd prefer to keep the dir names for the modules to match the jar names. And I think the jar names should be like 'pekko-actor', etc.

from pekko.

mdedetrich avatar mdedetrich commented on August 15, 2024

I'd prefer to keep the dir names for the modules to match the jar names.

Right, but this is only the case for core akka, every other akka repo does not follow in this. In fact arguably from what I have seen in standard OS SBT projects, this isn't really idiomatic or standard practice either (i.e. having folders the same as jar names). There is no correlation of folder name to jar, and hence in some cases it can be misleading.

And I think the jar names should be like 'pekko-actor', etc.

This would be unchanged even with my suggestion, in fact its very easy to do this with SBT.

Would you be more open if I created a PR demonstrating this? Its actually not that hard.

from pekko.

pjfanning avatar pjfanning commented on August 15, 2024

sure, try it out

from pekko.

spangaer avatar spangaer commented on August 15, 2024

I guess this is what #71 is about.

from pekko.

pjfanning avatar pjfanning commented on August 15, 2024

#71 is merged

from pekko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.