Giter VIP home page Giter VIP logo

Comments (8)

mdedetrich avatar mdedetrich commented on August 15, 2024 1

I would say it's still currently being worked on (as in I am going through each pekko git report and putting the checks in)

from pekko.

pjfanning avatar pjfanning commented on August 15, 2024

This is something we will want to implement. I'm not yet sure that we have enough stability in the dev pipelines though.

In the end of the day, we are months away from any releases, anything that sneaks into the main branch can be fixed - this will hopefully be rare.

from pekko.

spangaer avatar spangaer commented on August 15, 2024

Explicitly having to name the status checks for that feature to do anything meaningful, is an additional complication.

from pekko.

mdedetrich avatar mdedetrich commented on August 15, 2024

This is something we will want to implement. I'm not yet sure that we have enough stability in the dev pipelines though.

So we don't have to enable all of the status checks however there are ones that make sense to enable even now, i.e.

  • Scalafmt / Code is formatted (pull_request)
  • Pull Requests / Check / Headers (pull_request)

And all of the compile ones (I don't think we ever want to merge code that actually can't compile)

Also do note that even with status checks enabled you can bypass them, you just need to write permissions to the repo (which in the current case I think is PMC members?).

Explicitly having to name the status checks for that feature to do anything meaningful, is an additional complication.

I don't know what you mean, if you are talking about the logistics of enabling them then its really quite trivial, you get a dropdown of past checks that have triggered (which we are already at this point in time) and you just select the ones that you want to enable.

I manage projects that I have write/admin access to and this is really a trivial 5 minute job.

from pekko.

spangaer avatar spangaer commented on August 15, 2024

From UI it's not very complicated, from API there's a couple of pitfalls, which I assume will extrapolate to this asf.yml file.

from pekko.

mdedetrich avatar mdedetrich commented on August 15, 2024

From UI it's not very complicated, from API there's a couple of pitfalls, which I assume will extrapolate to this asf.yml file.

Ah thats what you mean, I assume if there is an example Apache project with a configuration it shouldn't be too hard to figure out.

from pekko.

sam-byng avatar sam-byng commented on August 15, 2024

Is there anything left on this?
It seems we have pipelines working, and we have mandatory pipeline passing + 1 review before merge. So the card is done.

from pekko.

mdedetrich avatar mdedetrich commented on August 15, 2024

This has already been done, closed.

from pekko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.