Comments (4)
oh, sorry, some error is too large in some test.
Those test case will need to be fixed, e.g.
test_averagepool_2d_same_lower_cpu
Max absolute difference: 1.3230393
Max relative difference: 3.
from singa.
@chrishkchris I have fixed the average pool and max pool issues above in #746
However, for the equal, I found this is because there is some error when we do the sub
operator for int32 input:
for example for input:
A = np.array([[[17, 4, 9, 22, 18], [-9, 9, -1, -1, 4], [1, 14, 7, 1, 4],
[3, 14, -2, 3, -8]],
[[-25, 6, 8, -7, 22], [-14, 0, -1, 15, 14],
[1, 3, -8, -19, -3], [1, 12, 12, -3, -3]],
[[-10, -14, -17, 19, -5], [-4, -12, 7, -16, -2],
[-8, 3, -5, -11, 0], [4, 0, 3, -6, -3]]],
dtype=np.int32)
B = np.array([[[-6, -3, -8, -17, 1], [-4, -16, 4, -9, 0],
[7, 1, 11, -12, 4], [-6, -8, -5, -3, 0]],
[[-11, 9, 4, -15, 14], [18, 11, -1, -10, 10],
[-4, 12, 2, 9, 3], [7, 0, 17, 1, 4]],
[[18, -13, -12, 9, -11], [19, -4, -7, 19, 14],
[18, 9, -8, 19, -2], [8, 9, -1, 6, 9]]],
dtype=np.int32)
The result of singa.__sub__(a, b)
is:
[[[ -6 -3 -8 -17 17]
[ -9 -3 -1 -1 3]
[ -6 -3 -8 -17 3]
[ -6 -3 -2 -17 -8]]
[[ -25 -3 -8 -7 21]
[ -14 -3 -1 -17 13]
[ -6 -3 -8 -19 -3]
[ -6 -3 -8 -3 -3]]
[[ -10 -14 -17 -17 -5]
[ -4 -12 -8 -16 -2]
[ -8 -3 -5 -11 -2147483647]
[ -6 -3 -8 -6 -3]]]
Fs[[[ -6 -3 -8 -17 17]
[ -9 -16 -1 -1 4]
[-2147483642 13 -2147483644 -12 0]
[ -6 -8 -2 -3 -8]]
[[ -25 -2147483645 4 -7 8]
[ -14 -2147483637 -1 -10 4]
[ -4 -2147483639 -8 -19 -3]
[-2147483642 12 -2147483643 -3 -3]]
[[ -10 -14 -17 10 -5]
[ -4 -12 -7 -16 -2]
[ -8 -2147483642 -5 -11 -2]
[-2147483644 -2147483639 -1 -6 -3]]]
The correct result should be:
[[[ 23, 7, 17, 39, 17],
[ -5, 25, -5, 8, 4],
[ -6, 13, -4, 13, 0],
[ 9, 22, 3, 6, -8]],
[[-14, -3, 4, 8, 8],
[-32, -11, 0, 25, 4],
[ 5, -9, -10, -28, -6],
[ -6, 12, -5, -4, -7]],
[[-28, -1, -5, 10, 6],
[-23, -8, 14, -35, -16],
[-26, -6, 3, -30, 2],
[ -4, -9, 4, -12, -12]]]
@dcslin can we fix it?
from singa.
@chrishkchris I have fixed the average pool and max pool issues above in #746
However, for the equal, I found this is because there is some error when we do the
sub
operator for int32 input:for example for input:
A = np.array([[[17, 4, 9, 22, 18], [-9, 9, -1, -1, 4], [1, 14, 7, 1, 4], [3, 14, -2, 3, -8]], [[-25, 6, 8, -7, 22], [-14, 0, -1, 15, 14], [1, 3, -8, -19, -3], [1, 12, 12, -3, -3]], [[-10, -14, -17, 19, -5], [-4, -12, 7, -16, -2], [-8, 3, -5, -11, 0], [4, 0, 3, -6, -3]]], dtype=np.int32) B = np.array([[[-6, -3, -8, -17, 1], [-4, -16, 4, -9, 0], [7, 1, 11, -12, 4], [-6, -8, -5, -3, 0]], [[-11, 9, 4, -15, 14], [18, 11, -1, -10, 10], [-4, 12, 2, 9, 3], [7, 0, 17, 1, 4]], [[18, -13, -12, 9, -11], [19, -4, -7, 19, 14], [18, 9, -8, 19, -2], [8, 9, -1, 6, 9]]], dtype=np.int32)
The result of
singa.__sub__(a, b)
is:[[[ -6 -3 -8 -17 17] [ -9 -3 -1 -1 3] [ -6 -3 -8 -17 3] [ -6 -3 -2 -17 -8]] [[ -25 -3 -8 -7 21] [ -14 -3 -1 -17 13] [ -6 -3 -8 -19 -3] [ -6 -3 -8 -3 -3]] [[ -10 -14 -17 -17 -5] [ -4 -12 -8 -16 -2] [ -8 -3 -5 -11 -2147483647] [ -6 -3 -8 -6 -3]]] Fs[[[ -6 -3 -8 -17 17] [ -9 -16 -1 -1 4] [-2147483642 13 -2147483644 -12 0] [ -6 -8 -2 -3 -8]] [[ -25 -2147483645 4 -7 8] [ -14 -2147483637 -1 -10 4] [ -4 -2147483639 -8 -19 -3] [-2147483642 12 -2147483643 -3 -3]] [[ -10 -14 -17 10 -5] [ -4 -12 -7 -16 -2] [ -8 -2147483642 -5 -11 -2] [-2147483644 -2147483639 -1 -6 -3]]]
The correct result should be:
[[[ 23, 7, 17, 39, 17], [ -5, 25, -5, 8, 4], [ -6, 13, -4, 13, 0], [ 9, 22, 3, 6, -8]], [[-14, -3, 4, 8, 8], [-32, -11, 0, 25, 4], [ 5, -9, -10, -28, -6], [ -6, 12, -5, -4, -7]], [[-28, -1, -5, 10, 6], [-23, -8, 14, -35, -16], [-26, -6, 3, -30, 2], [ -4, -9, 4, -12, -12]]]
@dcslin can we fix it?
this int subtraction testing is fixed and added in #763
from singa.
solved by #763
from singa.
Related Issues (20)
- Switch between CPU and GPU devices for cnn example HOT 4
- Save the downloaded datasets to local directory HOT 2
- Add running scripts for cnn and cifar_distributed_cnn examples HOT 4
- Intermediate information printing HOT 3
- Adding arguments for weight decay and momentum HOT 2
- Increase max epoch for cnn example for better convergence HOT 2
- Update CMakeLists.txt for release 4.0.0 HOT 1
- Check Apache license header for release 4.0.0
- OpenCL Compilation Fails
- Upload Release 4.0.0 Package to SVN HOT 1
- Update the NOTICE file for images HOT 1
- gitignore and gitmodules should be removed from the release tar file HOT 2
- Create a new branch dev-postgresql HOT 2
- Create the SumError New Loss Function HOT 1
- Dynamic Creation of Models HOT 2
- Need to return the gradients from optimizer HOT 4
- Maximum recursion depth exceeded in comparison for string HOT 1
- can sparse all-reduce keep efficiency with large number of gpu workers?
- Python 3.11, Model, ImportError HOT 9
- Update documentation for distributed training HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from singa.