[SIP-123] Proposal replacement of data table components with ag-grid about superset HOT 14 OPEN

I've sent an email to the AG Grid team just to confirm that there won't be any licensing/EULA issues to contend with in our project, which might be used for commercial or non-commercial purposes. This seems like the occasion to ask for permission rather than forgiveness ;)

Also, the SIP makes no mention of converting the Table viz plugin to AG Grid, but assume that's a logical next step in the table roadmap if this phase goes according to plan?

from superset.

the SIP makes no mention of converting the Table viz plugin to AG Grid, but assume that's a logical next step in the table roadmap if this phase goes according to plan?

That's right.

from superset.

I've sent an email to the AG Grid team just to confirm that there won't be any licensing/EULA issues to contend with in our project, which might be used for commercial or non-commercial purposes. This seems like the occasion to ask for permission rather than forgiveness ;)

according to repo of ag-grid has a MIT license https://github.com/ag-grid/ag-grid?tab=MIT-1-ov-file#readme

from superset.

cc: #24318

from superset.

cc: #24319

from superset.

@justinpark also consider in the DataTable in chart-plugins the option to custom render of column for example we want present a list of tweets in a table with a column that renders to a hyperlink to navigate to a original tweet in twitter site.
I would like to contribute to the change of DataTable in chart-plugins

from superset.

we want present a list of tweets in a table with a column that renders to a hyperlink to navigate to a original tweet in twitter site.
I would like to contribute to the change of DataTable in chart-plugins

Your contribution to this change would be highly appreciated, and it can be pursued independently of the dependencies mentioned in the proposal. This is because this proposal involves overriding the existing column rendering logic, allowing you to implement the desired hyperlink functionality separately.

from superset.

I've sent an email to the AG Grid team just to confirm that there won't be any licensing/EULA issues to contend with in our project, which might be used for commercial or non-commercial purposes. This seems like the occasion to ask for permission rather than forgiveness ;)

Much appreciated @rusackas ❤️

Also, the SIP makes no mention of converting the Table viz plugin to AG Grid, but assume that's a logical next step in the table roadmap if this phase goes according to plan?

@justinpark I think it's important to add this to the SIP so folks that are not participating in the discussion can understand what's the plan. This depends on the reply of the Ag Grid folks and I can see two scenarios:

• Orgs are not allowed to use the community version of the table when commercializing Superset. In this scenario, all tables still default to AgGrid but we need to add a configuration to disable it and show the old table instead.
• No license restriction. We replace all tables and remove the old table.

During the SIP Office Hours, @yousoph also asked if there is any feature present in the current table that would not be available in AG Grid.

All this content could go under the Migration Plan and Compatibility section. We also need to add an example of how our theme could be applicable to the table to ensure visual consistency.

from superset.

Your contribution to this change would be highly appreciated

It would be a pleasure to contribute, could you give me a guide on the structure of the project to familiarize myself with the repository, if that is possible,
Is this the main thing to change?

https://github.com/apache/superset/tree/master/superset-frontend/plugins/plugin-chart-pivot-table

from superset.

I think it's important to add this to the SIP so folks that are not participating in the discussion can understand what's the plan. This depends on the reply of the Ag Grid folks and I can see two scenarios:

• Orgs are not allowed to use the community version of the table when commercializing Superset. In this scenario, all tables still default to AgGrid but we need to add a configuration to disable it and show the old table instead.
• No license restriction. We replace all tables and remove the old table.

We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. In light of this, this proposal suggests replacing all tables with ag-Grid.

from superset.

We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. In light of this, this proposal suggests replacing all tables with ag-Grid.

Wooohoooo! 🎉

from superset.

We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset.

Indeed. It looks like I forgot to mention that here, so thank you. Specifically, they stated in an email:

AG Grid community is free to download and use without the need to notify us.

As long as you are not using any of the features of AG Grid enterprise these will be no issue.

from superset.

Will #26364 column filter like the one in a be implemented?

from superset.

Will #26364 column filter like the one in a be implemented?

It can be a good idea for a follow-up improvement, but it is not included in the initial implementation. The implementation of a column filter like the one in #26364 would require further consideration and planning.

from superset.