[SIP-132] Proposal for SQL Lab addon plugins about superset HOT 3 OPEN

Thank you @justinpark. It's just the beginning of the discussion, given the complexity of the topic, but I would like to add something about the following:

We will provide an interface to access the current query editor context

As for what is available for the addons to consume, I believe we need to consider whether wider access to the state and actions might be helpful

It's really important that what we expose to the plugins should be defined under a versioned API instead of internal structures. The Redux state and actions are internal structures that can be changed at any time and are not versioned. Having a clear defined API is important to avoid the situation where plugins break because of internal changes and to provide clarity for plugin authors about the resources that they have access to in a particular version.

from superset.

I echo all of @geido's questions - particularly about the applicability to other areas of Superset. Our viz plugins, dashboard component extensions, etc. There are about a million places we'll want to add plugins eventually (formatters, advanced types, "export as" options, etc), so it would be great to arrive at an architecture that's repeatable/reusable for all of this an clean up house.

In a perfect world, I'd love to see these plugins managed through the UI (like an IDE does) where one can simply add npm URLs, and each "plugin" has its own webpack/tsconfig, so you simply point Superset at the bundle and load it dynamically. This would kick the doors open for a highly extensible Superset experience.

I'm guessing from the video that there's already some code that would be good to upstream. I love that advantage, but at the same time, I want to make sure we nail this... because if we do, it'll be an absolute game-changer for Superset.

from superset.

Thanks @justinpark, a few questions:

• Can this addon system be applied to other parts of Superset? Should the design be more generic to benefit beyond SQL Lab?
• Are addons tab-specific or user-specific? Clarifying this is essential to avoid user confusion, as it seems they are user-specific but displayed under individual tabs.
• Should administrators have control over which addons are available via a permission system?
• Also, I believe addons should be configurable at startup so that one can have control of what addons are available in the Superset instance
• As for what is available for the addons to consume, I believe we need to consider whether wider access to the state and actions might be helpful

from superset.