Giter VIP home page Giter VIP logo

Comments (4)

dosubot avatar dosubot commented on August 28, 2024 3

It looks like the discrepancy in row limits you're encountering could be due to different settings or contexts within your application. Here's a more focused approach to address your issue:

  1. Review Component Settings: Ensure that all instances where the row limit is applied in your application are consistent. Different parts of your application might have different row limits set for performance or analysis purposes.

  2. Configuration and Defaults: Check your application's configuration settings. For Apache Superset, for example, the default row limit can be adjusted in the superset/config.py file by modifying the ROW_LIMIT variable.

  3. Understand Contextual Use: The difference in row limits might be intentional, based on the functionality of different parts of your application. For instance, one section might limit data display for quick performance, while another allows more data for in-depth analysis.

  4. Adjust Limits if Necessary: If the varying limits are not intentional and cause confusion, consider harmonizing them across your application to ensure a consistent user experience.

The components like RowCountLabel and QueryLimitSelect in Apache Superset are designed to inform users about the number of rows returned and allow them to select query limits. These components do not directly affect the overall row limit but serve to enhance user interaction and understanding of data limits.

If filtering is causing confusion due to the row limit, remember that filtering actions only affect the visible subset of data and do not fetch additional data to meet the row limit. This means the displayed data after filtering is still within the initial fetch limit, not extending to the maximum row limit unless explicitly fetched.

If you need further assistance or clarification, feel free to ask.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a πŸ‘ if this is helpful and πŸ‘Ž if it is irrelevant.

To continue the conversation, mention @dosu.

from superset.

xavier-GitHub76 avatar xavier-GitHub76 commented on August 28, 2024 1

Hello,

Thank you for the clarifications provided.

There are several ways to limit the number of rows :

  • config.py : ROW_LIMIT, DISPLAY_MAX_ROW (maybe others)
  • the drop-down list in SQLLAB

The drop-down list could take the most restrictive of these variables as its maximum value.

Thus the user would make a choice that is always achievable.
This would also avoid having a surprising error message.
Currently the message tells the user to modify their query by adding a limit or a filter to display 100,000 values ​​even though they will technically never be able to reach this number of rows.

Sincerely

from superset.

rusackas avatar rusackas commented on August 28, 2024

Dosu is almost right. There is a ROW_LIMIT config, but that's for chart data.

The error you see right there in the UI, however IS correct.

DISPLAY_MAX_ROW in config.py is set by default to 10,000, and that's the limit you're hitting, just like it says. You can raise it in your config if you'd like.

Admittedly, it's not a great experience that the UI even shows higher than you're allowed to request... maybe that Select menu should look up and respect the DISPLAY_MAX_ROW setting, and/or display it in a tooltip so the user is more aware of it. If you feel like opening a PR to make it better, that would be cool!

from superset.

rusackas avatar rusackas commented on August 28, 2024

If you want to propose a change, and/or open a PR to that effect, I think folks would be supportive!

from superset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.