Comments (5)
It seems like this issue requires a deeper look. @rusackas, could you please lend your expertise?
Details
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
To continue the conversation, mention @dosu.
from superset.
The issue you're experiencing with the "ROW_LIMIT" setting not being applied correctly could be due to several factors, including recent changes in the Superset codebase, backend configurations, or frontend control logic. Here are some steps and considerations to help you resolve this issue:
Backend Configurations
Ensure that the backend configurations in config.py
are not overriding your "ROW_LIMIT" setting. Key settings to check include:
- SQL_MAX_ROW: Defines the maximum number of rows returned for any analytical database query.
- DISPLAY_MAX_ROW: Limits the number of rows displayed in the SQL Lab UI.
- DEFAULT_SQLLAB_LIMIT: Default row limit for SQL Lab queries.
- SUPERSET_META_DB_LIMIT: Limit when the feature flag
ENABLE_SUPERSET_META_DB
is on. - SQLLAB_CTAS_NO_LIMIT: Allows SQL Lab to run queries without a row limit when using the CTAS feature.
Frontend Control Logic
Ensure that the value you set (20,000,000) is within the allowed options or is correctly validated as a free-form input. The row_limit
control is defined with specific options and validation logic.
Recent Changes in Superset Codebase
There have been recent changes in the Superset codebase that might affect the "ROW_LIMIT" setting. Notably, pull requests #27700 and #26151 address issues related to row limits.
Logging and Debugging
Superset has logging mechanisms that can help trace how the "ROW_LIMIT" setting is being applied or ignored during query execution. Key logging statements are present in the superset/commands/sql_lab/execute.py
file.
Visibility of row_limit
Control
Ensure that the server_pagination
control is not enabled, as it might be causing the "ROW_LIMIT" setting to be ignored.
If the problem persists, consider reviewing the recent changes in the Superset codebase that might affect the behavior of the "ROW_LIMIT" setting.
It seems like this issue requires a deeper look, @rusackas could you please lend your expertise?
Details
Sources
- Limit issue
- superset/migrations/versions/2019-06-04_10-12_d7c1a0d6f2da_remove_limit_used_from_query_model.py
- superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/limits.ts
- superset-frontend/src/explore/controls.jsx
- superset/config.py
- docker/pythonpath_dev/superset_config.py
- superset/sql_lab.py
- superset/commands/sql_lab/execute.py
- CHANGELOG/3.1.0.md
- CHANGELOG/4.0.1.md
- superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
- superset-frontend/src/SqlLab/components/ResultSet/index.tsx
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
To continue the conversation, mention @dosu.
from superset.
Ho @mujohiddin. This bug was fixed by #26807 which is available in 3.1.3 and 4.0.1 so you just need to use one of these versions. You can always check in which version a fix is available using the CHANGELOG.
FYI: It's not a good practice to tag multiple people multiple times. Keep in mind that we receive many messages every day and might be busy resolving other issues.
from superset.
I have run my superset project version for the first time since September October last year, I tried the above solutions and it didn't work
@dosu._
from superset.
Hello, you mentionned a september / october version. I recalled we faced the same issue around the same period, it was solved for us since 3.1.3.
from superset.
Related Issues (20)
- 50 - Deprecate the KV_STORE feature flag HOT 3
- [SIP-137] Can we limit a user to only read certain tables in the database connection? HOT 6
- SPAM
- Version 4.0.1: Unable to adjust the size of a chart in a dashboard when the chart touches the right edge of the dashboard HOT 4
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- SPAM
- Default native filters values don't set correctly HOT 1
- Superset 4.0.1 - Exported CSV Contains Garbled Chinese Characters and Numbers HOT 10
- Metric datatype incorrect when swap dataset HOT 1
- It is proposed to add the feature of grouping like folders HOT 3
- TimeSeries Chart is showing Year for the January month HOT 5
- Storybook controls are out of date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superset.