Comments (6)
ping @pksunkara @zdne
please take a look
same result for array
from drafter.
As I said, this is intentional. The AST produced by snowcrash should depict what the user exactly wrote. Even though, they mean the same, they can be represented differently in the AST.
Although, there is a different bug in this too. apiaryio/snowcrash#286
from drafter.
Oh sry for duplicity, issue apiaryio/snowcrash#286 I miss.
I'm in trouble in refract AST implementation because there is no way to say if value is sample.
Except workarround, while I check last && first value for presence of asterisk, and cut them from literal.
But I mean it is really weird solution!
What do you mean about it @zdne ?
from drafter.
The AST produced by snowcrash should depict what the user exactly wrote
Originally this was the case, yes. However as we are moving forward this should not be the case in a future. I would strongly recommend to move away from different AST for different notations of the same thing (as is the case here). Instead – in a future – both should be parsed into the same structure (refract tree). It is the task for a (future) source map to help user – if needed – to figure out whether the sample value comes from one line or multiple lines.
So I do not think this is a bug at the moment, however when we move to parsing into refract I would move away fro this practice (it will also make manipulation with the parse (refract) tree a lot easier).
from drafter.
@klokane as for any issues with refract implementation – can we discuss it over Slack or in person?
from drafter.
@zdne i mean, better will be personal with public output opened for comments
from drafter.
Related Issues (20)
- Missing resource name renders incorrect output but it is validated
- Confusing AST for enum examples HOT 4
- Compatibility with MSVC 2019 HOT 1
- Building drafter-cli causes a link "warning" (macOS)
- Duplicit value in enumeration HOT 2
- Missing description after wrongly interpreted MSON `enum[string], fixed`
- PEGTL not fixed to specific version HOT 1
- Drafter backend crashes on unexpanded `Include (object)` HOT 1
- sigsegv
- Include Drafter version in ABI HOT 2
- Parser emits that `false` is not allowed boolean type for default HOT 1
- Ninja can no longer build due to cycling input HOT 2
- Drafter version does not work for CMake builds
- Docker hub entry outdated HOT 1
- Distinct OneOf gets parsed as single OneOf group in schema HOT 5
- Fixed array with a mixin inside produces incorrect json schema
- Building drafter is painfully slow. HOT 3
- Drafter for Java
- Compile error with newer gcc
- [build] CMake build on RHEL 9 is missing libraries HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drafter.