Giter VIP home page Giter VIP logo

Comments (4)

B4nan avatar B4nan commented on May 26, 2024

ooops, should have been a PR :] reposting the commit message here:

The link to PuppeteerPool won't work as the page is no longer part of 1.0 sdk docs,
found a note about it being deprecated and replaced with BrowserPool, but i'd rather
let you handle that change as I don't fully understand all the differences.

from actor-scraper.

mnmkng avatar mnmkng commented on May 26, 2024

@B4nan Is this still relevant?

from actor-scraper.

B4nan avatar B4nan commented on May 26, 2024

Fixed the links for AutoscaledPool only, as said above, the link for PuppeteerPool is not valid in v1, so that goes to 404. Not sure how we wanna handle that, probably the mention about PuppeteerPool should be removed?

And apparently the docs (on web, not sdk docs) will need a rebuild, the AutoscaledPool is still not working - I fixed it only in this repo as I thought it is taken from here, but might be a duplicated content somewhere else.

Btw we might also make the old links just work (add redirects and keep the old url working too). I know how to do that in docusaurus v2, but there will be probably same/similar way to do so in v1 too.

e.g. this is how I am handling old URLs that were directy on the domain (/custom-driver), but now they are under /docs/custom-driver:

https://github.com/mikro-orm/mikro-orm/blob/master/docs/static/custom-driver/index.html

from actor-scraper.

mnmkng avatar mnmkng commented on May 26, 2024

Redirects are not easy to do in v1. Will have to do it once we migrate to v2. I would point the invalid puppeteer pool link to https://github.com/apify/browser-pool for now.

from actor-scraper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.