Giter VIP home page Giter VIP logo

Comments (4)

fnesveda avatar fnesveda commented on May 30, 2024

http_client.call returns a httpx.Response which is in some cases enhanced with a _maybe_parsed_body. It's a bit of a hack which was really useful when we still used requests, and simplified the code a lot, but when we switched to using httpx and did some more changes, it ended up being used only in one method, when fetching a key-value store record body. So now we could put the "maybe" response parsing into that method, instead of having it in the http_client, to have a better separation of concerns, and less hacks.

from apify-client-python.

vdusek avatar vdusek commented on May 30, 2024

My IDE was not able to recognize that, instead it raised an accessing of non-existing field error. The self.http_client.call is annotated to return httpx.Response object. So it might be the source of the problem.

from apify-client-python.

fnesveda avatar fnesveda commented on May 30, 2024

Yeah, that's probably it. I wonder how this ever passed lint without a #noqa comment 🤷

from apify-client-python.

vdusek avatar vdusek commented on May 30, 2024

Yeah, that's probably it. I wonder how this ever passed lint without a #noqa comment 🤷

I think because accessing fields is checked by Mypy. That's the reason why there is # type: ignore .

from apify-client-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.