Comments (10)
@twifty arrays aren't being querystringify'd properly due to buildQuerystring
(https://github.com/apocas/docker-modem/blob/master/lib/modem.js#L350). Arrays are being stringify'd before being passed to querystring
.
/cc @apocas
from docker-modem.
Interesting, will check this one.
from docker-modem.
I can't replicated this, there's even a test for this.
https://github.com/apocas/docker-modem/blob/master/test/modem_test.js#L109
INPUT:
var opts = {
"limit": 12,
"filters": {
"label": ["staging", "env=green"]
},
"t": ["repo:latest", "repo:1.0.0"]
};
OUTPUT:
limit=12&filters={"label":["staging","env=green"]}&t=repo:latest&t=repo:1.0.0
The array "t" was properly converted.
from docker-modem.
@apocas the test case works because of key !== 't'
Line 351 in 01cac74
from docker-modem.
Missed that. Can't remember why that was done.
I suspect that endpoints didn't behave the same way, regarding input.
Will check if removing the stringify doesn't break anything.
from docker-modem.
Passes: https://github.com/apocas/dockerode/blob/master/test/docker.js#L648
Fails: https://github.com/apocas/dockerode/blob/master/test/docker.js#L658
So we can't just remove the stringify. Add that parameter as an exception?
from docker-modem.
@apocas looks like it was introduced with this commit: 8565c3f. Regarding my use case, as far as I remember it was related to passing an array of environment variables when creating/starting (not sure) a Docker container using dockerode. It was not working and debug'd down to this part of the code in docker-modem.
from docker-modem.
But we can't just remove this condition because the are endpoints expecting the data "stringifed". Like https://github.com/apocas/dockerode/blob/master/test/docker.js#L658
On the other hand there are parameters that are expected by Docker to be repeated like "t" in imageBuild. https://docs.docker.com/engine/api/v1.40/#operation/ImageBuild
"A name and optional tag to apply to the image in the name:tag format. If you omit the tag the default latest value is assumed. You can provide several t parameters."
If "extrahosts" is one of this cases we can add it to the exception list, like "t".
(Docker documentation does not detail this enough in this use case)
from docker-modem.
@apocas I tried to get multiple images, I need to pass names as array to query, but it doesn't work.
I think you need to check the opts[key]
is Array or not
from docker-modem.
Same here, i was working with the getImages function from dockerode and i discovered the query string is not created as expected.
My object
{
names: ["name1", "name2"]
}
gets changed to
{
names: "[\"name1\", \"name2\"]"
}
in the cloned object and the querystring created by it it's incorrect.
/images/get?names=%5B%22name1%22%2C%22name2%22%5D
instead of
/images/get?names=name1&names=name2
Happy to help if you want!!
from docker-modem.
Related Issues (20)
- Why does followProgress require JSON output? HOT 1
- v3.0.1 causes error: "invalid character '/' looking for beginning of value" HOT 1
- Upgrade `ssh` to `1.8.0`. HOT 3
- dial() can call callback multiple times HOT 2
- Bug: followProgress throw an error on exporting images
- Wrong type on buffer response HOT 3
- [Proposal] add error event handler HOT 1
- Use the new Mac Docker socket default path, if present HOT 1
- incompatibility on Bun.js HOT 2
- Troubles with demuxStream called from docker.run HOT 1
- Bug: Vulnerability issue in ssh2 1.14.0 HOT 1
- Since v5 DOCKER_HOST is not resolved on macOS with OrbStack
- Q: Why HTTP?
- Restore exec output stream HOT 1
- Bug: pathPrefix or any host path is ignored
- ERR_STRING_TOO_LONG when getting a long list of images
- How does SSH connection works for user/password method? HOT 1
- 'image.push()' returns server error as 'Error: (HTTP code 500) server error - [object Object]'
- Error - streama.on('data', onStreamEvent);
- Uncatchable DNS errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-modem.