Comments (6)
@apoclyps do you mean options instead?
https://click.palletsprojects.com/en/7.x/options/#options
from reviews.
Yes, thanks for making a note that options was the correct usage here.
I'll check out your WIP shortly and see if there is any way we can do this. It may be a limitation of the library being used or a feature that isn't generally supported.
from reviews.
This may not be possible using the existing classes in the rich library because of the following:
The live display will persist for the duration of the context. You can update the renderable to update the display
https://rich.readthedocs.io/en/stable/live.html#basic-usage
transient (bool, optional): Clear the renderable on exit (has no effect when screen=True). Defaults to False.
https://github.com/willmcgugan/rich/blob/f513abd35fdacccdc6fcbcc6989b5792b75ec97a/rich/live.py#L43
Setting transient=False, screen=False
allows the UI to persist however it tends to flicker a lot whilst rendering. To achieve this without flickering, we might need to create another render
that only performs a single render with the completed results once completed with the required settings.
from reviews.
@apoclyps do you mean options instead?
I've started working on this, but am currently facing an issue where when I quit off the main loop, the last refreshed display goes away with it and thus is useless -- I've referred to the docs regarding transient display but that's not really helpful too. Will see if there's any other way to accomplish this
from reviews.
This may not be possible using the existing classes in the rich library because of the following:
The live display will persist for the duration of the context. You can update the renderable to update the display
https://rich.readthedocs.io/en/stable/live.html#basic-usage
transient (bool, optional): Clear the renderable on exit (has no effect when screen=True). Defaults to False.
https://github.com/willmcgugan/rich/blob/f513abd35fdacccdc6fcbcc6989b5792b75ec97a/rich/live.py#L43
Setting
transient=False, screen=False
allows the UI to persist however it tends to flicker a lot whilst rendering. To achieve this without flickering, we might need to create anotherrender
that only performs a single render with the completed results once completed with the required settings.
I tried an idea after looking at this and it seems to be working -- i set screen= not no_reload
here
from reviews.
For a larger number of repositories and pull requests the screen flickering is still an issue in #76
I've implemented an alternative solution in #78 - I would like to know your opinions on the solution.
from reviews.
Related Issues (20)
- [Feature] Provide configuration via config files HOT 3
- [FEATURE] Add support for corporate-hosted github HOT 4
- [FEATURE] Add support for inline diffs on pull requests HOT 2
- [BUG] Async isn't actually being used, and prevents ctrl+c from correctly exiting the app HOT 1
- [BUG] Does not seem to work with on premise git enterprise HOT 5
- [BUG] Bad/missing credentials are not handled graciously HOT 2
- [FEATURE] Names of the environment variable are somewhat generic HOT 2
- [Feature] Add flag to dashboard to hide/show authors pull requests HOT 13
- [Feature] Add support for Gitlab HOT 5
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- replace with pull_request.web_url
- - pass in link
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- Cant get settings file to work HOT 4
- Reviews does not appear to find .env file in current directory? HOT 3
- Request for PAT requirements documentation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviews.