Giter VIP home page Giter VIP logo

Comments (2)

yushao2 avatar yushao2 commented on May 27, 2024 1

I will take a stab at this

from reviews.

apoclyps avatar apoclyps commented on May 27, 2024

As discussed with @yushao2 in #53 , we have decided to increase the scope of this ticket to include configurable labels and colours to support the wide variety of labels that are non-standard or default.

If no user configuration is provided we should provide a default configuration for common labels and colours

  • docker: purple
  • security: red,
  • python: green,

If a custom configuration is provided we should replace the default configuration with the values provided.

You may find the get_configuration function useful in reviews/config.py as it accepts a comma-separated list of values for REPOSITORY_CONFIGURATION and convert's it to another format: https://github.com/apoclyps/reviews/blob/main/reviews/config.py#L28-L39

For example:

export LABEL_CONFIGURATION="python/green,docker/purple,security:red"

could be converted to one of the supported colours available within https://rich.readthedocs.io/en/latest/_modules/rich/color.html?highlight=green

label_config = {
    "python": "green",
    "docker": "purple",
    "security": "red",
}

then when we apply the labels in

labels = ", ".join([label.name for label in pr.labels])
, we could lookup the label key against the dict key, and set the value if one exists.

from reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.