Comments (2)
I will take a stab at this
from reviews.
As discussed with @yushao2 in #53 , we have decided to increase the scope of this ticket to include configurable labels
and colours
to support the wide variety of labels that are non-standard or default.
If no user configuration is provided we should provide a default configuration for common labels and colours
docker
:purple
security
:red
,python
:green
,
If a custom configuration is provided we should replace the default configuration with the values provided.
You may find the get_configuration
function useful in reviews/config.py
as it accepts a comma-separated list of values for REPOSITORY_CONFIGURATION
and convert's it to another format: https://github.com/apoclyps/reviews/blob/main/reviews/config.py#L28-L39
For example:
export LABEL_CONFIGURATION="python/green,docker/purple,security:red"
could be converted to one of the supported colours available within https://rich.readthedocs.io/en/latest/_modules/rich/color.html?highlight=green
label_config = {
"python": "green",
"docker": "purple",
"security": "red",
}
then when we apply the labels in
reviews/reviews/layout/helpers.py
Line 38 in fbd8b23
from reviews.
Related Issues (20)
- [Refactor] extract pull request render logic into individual field based functions
- [Feature] Provide configuration via config files HOT 3
- [FEATURE] Add support for corporate-hosted github HOT 4
- [FEATURE] Add support for inline diffs on pull requests HOT 2
- [BUG] Async isn't actually being used, and prevents ctrl+c from correctly exiting the app HOT 1
- [BUG] Does not seem to work with on premise git enterprise HOT 5
- [BUG] Bad/missing credentials are not handled graciously HOT 2
- [FEATURE] Names of the environment variable are somewhat generic HOT 2
- [Feature] Add flag to dashboard to hide/show authors pull requests HOT 13
- [Feature] Add support for Gitlab HOT 5
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- replace with pull_request.web_url
- - pass in link
- refactor this function for usage with Gitlab
- refactor this function to accept a link
- Cant get settings file to work HOT 4
- Reviews does not appear to find .env file in current directory? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviews.