Failing integration test: throws an error if invalid content-type about apollo-server-integration-h3 HOT 3 CLOSED

Looks right to me! I think we do something similar in one of the other integrations if you poke around. In any case, seems correct and the test is passing so 👍

from apollo-server-integration-h3.

So the error happens in this test:

https://github.com/apollographql/apollo-server/blob/fd48f2ca49ae7992515ec78b62d65f2d9a7921a9/packages/integration-testsuite/src/httpServerTests.ts#L338-L353

And the code that's testing is here:
https://github.com/apollographql/apollo-server/blob/ff69ee5bc2564fa757e5407e76b7bb184b4cd6cb/packages/server/src/runHttpQuery.ts#L128-L132

I'll need to look a bit more closely when I have more time. Can you share the body on the HTTPGraphQLRequest? I can do some debugging, though probably not until Monday.

from apollo-server-integration-h3.

Thanks for your help!

I just debugged this. The body is the object

{
  query: "query test{ testString }",
}

and thus passes the isNonEmptyStringRecord test. I guess the problem was that I always parsed the body as json, regardless of the content-type header. I've fixed that now in f2d84cd. Let me know if you think that's not the right way to proceed.

from apollo-server-integration-h3.